3wordchant/oasis
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Hide private messages from author profiles

Browse Source 
Problem: Showing private posts on profiles is scary and may give people
the impression that these posts are visible.
https://github.com/fraction/oasis/issues/113

Solution: Hide private messages when rendering public profiles and
change the method name to be very clear that it only returns public
messages.
This commit is contained in:
Christian Bundy 2020-01-28 17:13:32 -08:00
parent 82f080f3c6
commit 53c1a1ad94
3 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
package-lock.json generated
View File

@ -936,6 +936,7 @@
"requires": { "requires": {
"anymatch": "~3.1.1", "anymatch": "~3.1.1",
"braces": "~3.0.2", "braces": "~3.0.2",
"fsevents": "~2.1.2",
"glob-parent": "~5.1.0", "glob-parent": "~5.1.0",
"is-binary-path": "~2.1.0", "is-binary-path": "~2.1.0",
"is-glob": "~4.0.1", "is-glob": "~4.0.1",
@ -2865,6 +2866,13 @@
"resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz", "resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz",
"integrity": "sha1-FQStJSMVjKpA20onh8sBQRmU6k8=" "integrity": "sha1-FQStJSMVjKpA20onh8sBQRmU6k8="
}, },
"fsevents": {
"version": "2.1.2",
"resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.1.2.tgz",
"integrity": "sha512-R4wDiBwZ0KzpgOWetKDug1FZcYhqYnUYKtfZYt4mD5SBz76q0KR4Q9o7GIPamsVPGmW3EYPPJ0dOOjvx32ldZA==",
"dev": true,
"optional": true
},
"function-bind": { "function-bind": {
"version": "1.1.1", "version": "1.1.1",
"resolved": "https://registry.npmjs.org/function-bind/-/function-bind-1.1.1.tgz", "resolved": "https://registry.npmjs.org/function-bind/-/function-bind-1.1.1.tgz",

4
src/index.js
View File

@ -132,7 +132,7 @@ router
const description = await about.description(feedId); const description = await about.description(feedId);
const name = await about.name(feedId); const name = await about.name(feedId);
const image = await about.image(feedId); const image = await about.image(feedId);
const messages = await post.fromFeed(feedId); const messages = await post.fromPublicFeed(feedId);
const relationship = await friend.getRelationship(feedId); const relationship = await friend.getRelationship(feedId);
const avatarUrl = `/image/256/${encodeURIComponent(image)}`; const avatarUrl = `/image/256/${encodeURIComponent(image)}`;
@ -195,7 +195,7 @@ router
const name = await about.name(myFeedId); const name = await about.name(myFeedId);
const image = await about.image(myFeedId); const image = await about.image(myFeedId);
const messages = await post.fromFeed(myFeedId); const messages = await post.fromPublicFeed(myFeedId);
const avatarUrl = `/image/256/${encodeURIComponent(image)}`; const avatarUrl = `/image/256/${encodeURIComponent(image)}`;

4
src/models/index.js
View File

@ -435,7 +435,7 @@ module.exports = cooler => {
); );
const post = { const post = {
fromFeed: async (feedId, customOptions = {}) => { fromPublicFeed: async (feedId, customOptions = {}) => {
const ssb = await cooler.connect(); const ssb = await cooler.connect();
const myFeedId = ssb.id; const myFeedId = ssb.id;
@ -448,7 +448,7 @@ module.exports = cooler => {
source, source,
pull.filter( pull.filter(
msg => msg =>
typeof msg.value.content !== "string" && lodash.get(msg, "value.meta.private", false) === false &&
msg.value.content.type === "post" msg.value.content.type === "post"
), ),
pull.take(maxMessages), pull.take(maxMessages),