From e70088d9a160b60f0cafafc256258076be83ea9e Mon Sep 17 00:00:00 2001 From: cmorenov1402 Date: Wed, 23 Apr 2025 16:00:33 +0200 Subject: [PATCH] Refactor ChargeRefundListener to remove single-use variables and improve readability --- src/EventListener/ChargeRefundListener.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/EventListener/ChargeRefundListener.php b/src/EventListener/ChargeRefundListener.php index d6e4b1f..257f31e 100644 --- a/src/EventListener/ChargeRefundListener.php +++ b/src/EventListener/ChargeRefundListener.php @@ -35,12 +35,10 @@ class ChargeRefundListener return; } - $oldStatus = $args->getOldValue(self::FIELD_STATUS); - $newStatus = $args->getNewValue(self::FIELD_STATUS); - - $charged = ChargeStatus::Charged->value; - $toRefund = ChargeStatus::ToRefund->value; - if ($oldStatus === $charged && $newStatus === $toRefund) { + if ( + $args->getOldValue(self::FIELD_STATUS) === ChargeStatus::Charged + && $args->getNewValue(self::FIELD_STATUS) === ChargeStatus::ToRefund + ) { $refundStrategy = $charge->getCheckout()->getRefundStrategy(); match ($refundStrategy) { RefundStrategy::ToGateway => $this->processGatewayRefund($charge),