From fbbebbc7589b7b0c122b641645075df5690a25b5 Mon Sep 17 00:00:00 2001
From: Daniel Subiabre <daniel.subiabre@platoniq.net>
Date: Tue, 11 Feb 2025 12:22:29 +0100
Subject: [PATCH] Deprecate AccountingSeries for AccountingBalancePoint

---
 .../AccountingSeriesApiResource.php           | 54 -------------------
 src/Dto/AccountingSeriesDto.php               | 41 --------------
 .../AccountingBalancePointStateProvider.php   |  4 +-
 .../AccountingSeriesStateProcessor.php        | 48 -----------------
 4 files changed, 1 insertion(+), 146 deletions(-)
 delete mode 100644 src/ApiResource/Accounting/AccountingSeriesApiResource.php
 delete mode 100644 src/Dto/AccountingSeriesDto.php
 delete mode 100644 src/State/Accounting/AccountingSeriesStateProcessor.php

diff --git a/src/ApiResource/Accounting/AccountingSeriesApiResource.php b/src/ApiResource/Accounting/AccountingSeriesApiResource.php
deleted file mode 100644
index c56693d..0000000
--- a/src/ApiResource/Accounting/AccountingSeriesApiResource.php
+++ /dev/null
@@ -1,54 +0,0 @@
-<?php
-
-namespace App\ApiResource\Accounting;
-
-use ApiPlatform\Metadata as API;
-use App\Dto\AccountingSeriesDto;
-use App\State\Accounting\AccountingSeriesStateProcessor;
-
-/**
- * An AccountingSeries displays plottable, aggregated balance data over a time range for a given Accounting.\
- * \
- * AccountingSeries are calculated in real-time for each request from the available data for the Accountings,
- * each data point is a Money object representing the aggregated balance of the Accounting at that point in the series.\
- * \
- * Data points are relative to the series unit of time,
- * each point represents a lapse of `unit` over the `startDate`.
- */
-#[API\ApiResource(shortName: 'AccountingSeries')]
-#[API\Post(
-    input: AccountingSeriesDto::class,
-    processor: AccountingSeriesStateProcessor::class
-)]
-class AccountingSeriesApiResource
-{
-    /**
-     * The source Accounting for the data series.
-     */
-    public AccountingApiResource $accounting;
-
-    /**
-     * The start date for the data series.
-     */
-    public \DateTimeInterface $start;
-
-    /**
-     * The time unit for each data point in the series.
-     */
-    public string $interval;
-
-    /**
-     * The end date for the data series. Inclusive.
-     */
-    public \DateTimeInterface $end;
-
-    /**
-     * The number of data points in the series.
-     */
-    public int $length;
-
-    /**
-     * @var array<int, \App\Entity\Money>
-     */
-    public array $data;
-}
diff --git a/src/Dto/AccountingSeriesDto.php b/src/Dto/AccountingSeriesDto.php
deleted file mode 100644
index 94e8087..0000000
--- a/src/Dto/AccountingSeriesDto.php
+++ /dev/null
@@ -1,41 +0,0 @@
-<?php
-
-namespace App\Dto;
-
-use ApiPlatform\Metadata\ApiProperty;
-use App\ApiResource\Accounting\AccountingApiResource;
-use Symfony\Component\Validator\Constraints as Assert;
-
-class AccountingSeriesDto
-{
-    /**
-     * The source Accounting for the data series.
-     */
-    #[Assert\NotBlank()]
-    public AccountingApiResource $accounting;
-
-    /**
-     * The start date for the data series.
-     */
-    #[Assert\NotBlank()]
-    public \DateTimeInterface $start;
-
-    /**
-     * The time unit for each data point in the series,
-     * expressed as an integer followed by a time unit initial.
-     */
-    #[Assert\Choice(['24H'])]
-    public string $interval = '24H';
-
-    /**
-     * The end date for the data series. Inclusive.
-     */
-    #[Assert\LessThanOrEqual('now')]
-    #[ApiProperty(default: 'now')]
-    public ?\DateTimeInterface $end = null;
-
-    public function __construct()
-    {
-        $this->end ??= new \DateTimeImmutable('now');
-    }
-}
diff --git a/src/State/Accounting/AccountingBalancePointStateProvider.php b/src/State/Accounting/AccountingBalancePointStateProvider.php
index b719635..853eecb 100644
--- a/src/State/Accounting/AccountingBalancePointStateProvider.php
+++ b/src/State/Accounting/AccountingBalancePointStateProvider.php
@@ -25,9 +25,7 @@ class AccountingBalancePointStateProvider implements ProviderInterface
         $accounting = $this->getAccounting($parameters);
         $period = $this->buildPeriod($parameters);
 
-        $points = $this->accountingService->calcBalancePoints($accounting, $period);
-
-        dd($points);
+        return $this->accountingService->calcBalancePoints($accounting, $period);
     }
 
     private function getAccounting(Parameters $parameters): Accounting
diff --git a/src/State/Accounting/AccountingSeriesStateProcessor.php b/src/State/Accounting/AccountingSeriesStateProcessor.php
deleted file mode 100644
index cbd4ad1..0000000
--- a/src/State/Accounting/AccountingSeriesStateProcessor.php
+++ /dev/null
@@ -1,48 +0,0 @@
-<?php
-
-namespace App\State\Accounting;
-
-use ApiPlatform\Metadata\Operation;
-use ApiPlatform\State\ProcessorInterface;
-use App\ApiResource\Accounting\AccountingSeriesApiResource;
-use App\Dto\AccountingSerieDto;
-use App\Entity\Accounting\Accounting;
-use App\Mapping\AutoMapper;
-use App\Service\AccountingService;
-
-class AccountingSeriesStateProcessor implements ProcessorInterface
-{
-    public function __construct(
-        private AutoMapper $autoMapper,
-        private AccountingService $accountingService,
-    ) {}
-
-    /**
-     * @param AccountingSerieDto $data
-     *
-     * @return AccountingSeriesApiResource
-     */
-    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = [])
-    {
-        /** @var Accounting */
-        $accounting = $this->autoMapper->map($data->accounting, Accounting::class);
-
-        $points = $this->accountingService->calcBalanceSeries(
-            $accounting,
-            new \DatePeriod(
-                $data->start,
-                new \DateInterval(\sprintf('PT%s', $data->interval)),
-                $data->end,
-                \DatePeriod::INCLUDE_END_DATE
-            )
-        );
-
-        /** @var AccountingSeriesApiResource */
-        $series = $this->autoMapper->map($data, AccountingSeriesApiResource::class);
-
-        $series->data = $points;
-        $series->length = \count($points);
-
-        return $series;
-    }
-}