From c10bfaf68ef7de2d90f727e4ffcc6de2a2811a8a Mon Sep 17 00:00:00 2001
From: Daniel Subiabre <daniel.subiabre@platoniq.net>
Date: Tue, 11 Aug 2026 18:47:51 +0200
Subject: [PATCH] feat: show validation messages for all banner form fields

---
 src/actions/banners.ts                          | 10 +++++-----
 .../admin/comm/banners/BannersForm.svelte       | 17 ++++++++---------
 src/i18n/locales/es.json                        |  6 +++++-
 3 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/src/actions/banners.ts b/src/actions/banners.ts
index 0e09b185..feda4bc5 100644
--- a/src/actions/banners.ts
+++ b/src/actions/banners.ts
@@ -7,11 +7,11 @@ export const createBanner = defineAction({
     accept: "form",
     input: z.object({
         title: z.string("system.constraint.text.notEmpty").min(1),
-        description: z.string().min(1),
-        ctaText: z.string().min(1),
-        ctaLink: z.url(),
-        startsAt: z.coerce.date().min(new Date()),
-        endsAt: z.coerce.date().min(new Date()),
+        description: z.string("system.constraint.text.notEmpty").min(1),
+        ctaText: z.string("system.constraint.text.notEmpty").min(1),
+        ctaLink: z.url("system.constraint.text.expectedUrl"),
+        startsAt: z.coerce.date().min(new Date(), "system.constraint.date.greaterThan"),
+        endsAt: z.coerce.date().min(new Date(), "system.constraint.date.greaterThan"),
     }),
     handler: async (input, context) => {
         const { session, t } = context.locals;
diff --git a/src/components/admin/comm/banners/BannersForm.svelte b/src/components/admin/comm/banners/BannersForm.svelte
index f2557adb..a0267a60 100644
--- a/src/components/admin/comm/banners/BannersForm.svelte
+++ b/src/components/admin/comm/banners/BannersForm.svelte
@@ -1,11 +1,12 @@
 <script lang="ts">
     import { actions } from "astro:actions";
 
-    import { t } from "../../../../i18n/store";
+    import { locale, t } from "../../../../i18n/store";
     import ActionableButton from "../../../library/buttons/ActionableButton.svelte";
     import DateInput from "../../../library/inputs/DateInput.svelte";
     import TextArea from "../../../library/inputs/TextArea.svelte";
     import TextInput from "../../../library/inputs/TextInput.svelte";
+    import { formatDate } from "../../../../utils/dates";
 
     interface Props {
         onSubmit?: (event: SubmitEvent) => void;
@@ -24,7 +25,7 @@
     async function submit() {
         fieldErrors = {};
 
-        const { data, error } = await actions.createBanner(new FormData(formElement));
+        const { error } = await actions.createBanner(new FormData(formElement));
 
         if (error) {
             // @ts-expect-error fields does exist but astro typing sucks
@@ -34,8 +35,6 @@
                 Object.entries(errors ?? {}).map(([field, issues]) => [field, issues?.[0]]),
             ) as FieldErrors;
 
-            console.log(fieldErrors);
-
             return;
         }
     }
@@ -70,7 +69,7 @@
                 class="flex-1"
                 name="description"
                 placeholder={$t("pages.admin.comm.banners.fields.descriptionPlaceholder")}
-                error={fieldErrors.description}
+                error={fieldErrors.description && $t(fieldErrors.description)}
             />
 
             <div class="flex gap-6">
@@ -78,7 +77,7 @@
                     <TextInput
                         name="ctaText"
                         placeholder={$t("pages.admin.comm.banners.fields.ctaPlaceholder")}
-                        error={fieldErrors.ctaText}
+                        error={fieldErrors.ctaText && $t(fieldErrors.ctaText)}
                     />
                 </div>
 
@@ -86,7 +85,7 @@
                     <TextInput
                         name="ctaLink"
                         placeholder={$t("pages.admin.comm.banners.fields.urlPlaceholder")}
-                        error={fieldErrors.ctaLink}
+                        error={fieldErrors.ctaLink && $t(fieldErrors.ctaLink)}
                     />
                 </div>
             </div>
@@ -103,14 +102,14 @@
                 class="flex-1"
                 name="startsAt"
                 placeholder={$t("pages.admin.comm.banners.fields.startDatePlaceholder")}
-                error={fieldErrors.startsAt}
+                error={fieldErrors.startsAt && $t(fieldErrors.startsAt, { date: formatDate(new Date(), $locale) })}
             />
 
             <DateInput
                 class="flex-1"
                 name="endsAt"
                 placeholder={$t("pages.admin.comm.banners.fields.endDatePlaceholder")}
-                error={fieldErrors.endsAt}
+                error={fieldErrors.endsAt && $t(fieldErrors.endsAt, { date: formatDate(new Date(), $locale) })}
             />
         </div>
     </div>
diff --git a/src/i18n/locales/es.json b/src/i18n/locales/es.json
index 18318c03..1d78a322 100644
--- a/src/i18n/locales/es.json
+++ b/src/i18n/locales/es.json
@@ -19,7 +19,11 @@
     },
     "constraint": {
       "text": {
-        "notEmpty": "El texto no puede estar vacío"
+        "notEmpty": "El texto no puede estar vacío",
+        "expectedUrl": "No es una URL"
+      },
+      "date": {
+        "greaterThan": "La fecha debe ser mayor que {{ date }}"
       },
       "file": {
         "maxAllowedSize": "Tamaño máximo permitido 10MB",