PeachCloud/peach-dyndns-server
0
0
Fork 0
Code Issues 1 Pull Requests Projects Releases 1 Wiki Activity

Change to using jsonrpc instead of reqwest #13

Merged
mhfowler merged 8 commits from jsonrpc into master 2021-05-29 07:05:08 +00:00
Conversation 1 Commits 8 Files Changed 11 +473 -1235
mhfowler commented 2021-05-25 14:21:23 +00:00 (Migrated from github.com)
Copy Link

This PR changes peach-dyndns-server to use jsonrpc instead of rocket, to allow for parity with the other peach microservices (that run on peachcloud) and to provide a nice framework for uniformly structured success and error messages for API requests.

The new jsonrpc methods are:

  • register_domain(domain)
  • is_domain_available(domain)

The service is deployed to peach-vps in the same was as before, using cargo-deb. For convenience, you can run the script deploy_prod.sh which contains all relevant commands for building and installing the deb on peach-vps.

This PR changes peach-dyndns-server to use jsonrpc instead of rocket, to allow for parity with the other peach microservices (that run on peachcloud) and to provide a nice framework for uniformly structured success and error messages for API requests. The new jsonrpc methods are: - register_domain(domain) - is_domain_available(domain) The service is deployed to peach-vps in the same was as before, using cargo-deb. For convenience, you can run the script `deploy_prod.sh` which contains all relevant commands for building and installing the deb on peach-vps.
mhfowler commented 2021-05-29 07:05:03 +00:00 (Migrated from github.com)
Copy Link

@mycognosist I'm merging this now if you want to take a look at your convenience

@mycognosist I'm merging this now if you want to take a look at your convenience
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-dyndns-server#13
No description provided.
Delete Branch "jsonrpc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?