PeachCloud/peach-img-builder
0
0
Fork 0
Code Issues 6 Pull Requests Projects Releases Wiki Activity

Fix error generated by postinst scripts for peach services when systemd is not yet enabled #2

New Issue
Open
opened 2021-02-10 10:01:56 +00:00 by mhfowler · 3 comments
mhfowler commented 2021-02-10 10:01:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
mhfowler commented 2021-02-10 10:06:48 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@mycognosist I've found some stuff about this.

separate from cargo-deb, it appears this might be the idiomatic way to install systemd units in a debian package,
https://manpages.debian.org/testing/debhelper/dh_installsystemd.1.en.html,
this tool ensures that it doesn't matter if systemd is enabled or not at the time of installation

using cargo-deb (what we're using), it looks like August 21st of 2020 they added some new detailed documentation for doing this,
https://github.com/mmstick/cargo-deb/blob/master/systemd.md

so maybe we should refactor the cargo.toml for the services to use the method described here?

I'll test out
package.metadata.deb.systemd-units
for one service and see if it works, and fixes the vmdb2 issue

@mycognosist I've found some stuff about this. separate from cargo-deb, it appears this might be the idiomatic way to install systemd units in a debian package, https://manpages.debian.org/testing/debhelper/dh_installsystemd.1.en.html, this tool ensures that it doesn't matter if systemd is enabled or not at the time of installation using cargo-deb (what we're using), it looks like August 21st of 2020 they added some new detailed documentation for doing this, https://github.com/mmstick/cargo-deb/blob/master/systemd.md so maybe we should refactor the cargo.toml for the services to use the method described here? I'll test out package.metadata.deb.systemd-units for one service and see if it works, and fixes the vmdb2 issue
👍 1
mhfowler commented 2021-02-10 11:53:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Here is a PR for peach-oled which makes the change: https://github.com/peachcloud/peach-oled/pull/6/files

I've confirmed this works on the pi,
and also gets rid of the error during the vmdb2 build

If you think this sounds good,
then I can make PRs like this for all the other microservices

Here is a PR for peach-oled which makes the change: https://github.com/peachcloud/peach-oled/pull/6/files I've confirmed this works on the pi, and also gets rid of the error during the vmdb2 build If you think this sounds good, then I can make PRs like this for all the other microservices
mhfowler commented 2021-02-15 13:43:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

The one service remaining to fix this warning for is for peach-web, an open PR there still needs to be merged

The one service remaining to fix this warning for is for peach-web, an open PR there still needs to be merged
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 documentation
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 maintenance
Pruning and weeding
 peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
 refactor
Code rewrite
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
glyph (glyph) notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-img-builder#2