Build peach-config and refactor build scripts to share code #13

2021-03-11T09:55:09Z

mhfowler commented

2021-03-11 09:55:09 +00:00

(Migrated from github.com)

This PR includes:

renaming scripts folder to peach_package_builder for more clear python importing so that scripts can more easily share code
adding build_peach_config.py to build the peach-config debian module and add it to freight
change build_peach_go_sbot.py to manually hardcode version number. This is possibly the strangest change. I found that entering a version number via CLI was prone to error. I thought storing the version number in code, while somewhat tedious was perhaps more reliable. From looking at go-ssb repo, it seems not every PR has a version number that I can see, there is only a version 0.1.0 release tag that I've seen so far. So maybe its a good practice that we are doing our own version numbering. This perhaps gives us a little more selection too so we can only bring in the latest go-ssb code when we want to and have some control over this.
updates the README

Its a bit strange having three build scripts that all work a little differently,
but I guess that's also just what you get when we have packages written in three different languages (rust, python, go).

For simplicity, I've also made the script build_packages.py, which runs the python and rust build scripts. Notably, it does not run build_peach_go_sbot.py as that requires manually updating of the version number and can be run separately.

This PR includes: - renaming scripts folder to peach_package_builder for more clear python importing so that scripts can more easily share code - adding build_peach_config.py to build the peach-config debian module and add it to freight - change build_peach_go_sbot.py to manually hardcode version number. This is possibly the strangest change. I found that entering a version number via CLI was prone to error. I thought storing the version number in code, while somewhat tedious was perhaps more reliable. From looking at go-ssb repo, it seems not every PR has a version number that I can see, there is only a version 0.1.0 release tag that I've seen so far. So maybe its a good practice that we are doing our own version numbering. This perhaps gives us a little more selection too so we can only bring in the latest go-ssb code when we want to and have some control over this. - updates the README Its a bit strange having three build scripts that all work a little differently, but I guess that's also just what you get when we have packages written in three different languages (rust, python, go). For simplicity, I've also made the script build_packages.py, which runs the python and rust build scripts. Notably, it does not run build_peach_go_sbot.py as that requires manually updating of the version number and can be run separately.

👍 1

mycognosist (Migrated from github.com) approved these changes 2021-03-12 08:06:50 +00:00

mycognosist (Migrated from github.com) left a comment

Great - this is fantastic. The use of Python modules makes everything neat and easy to follow.

Sign in to join this conversation.

No reviewers

mycognosist