PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Replace absolute paths with relative paths for system command calls #100

Merged
glyph merged 1 commits from fix_sys_cmd_paths into main 2022-04-06 08:17:42 +00:00
Conversation 0 Commits 1 Files Changed 2 +4 -4
glyph commented 2022-04-06 08:17:17 +00:00
Owner
Copy Link

Fixes issue #94: Go-sbot service status query fails.

Since systemctl may not always be found at /usr/bin/systemctl (depending on OS and user preferences), it's best to invoke the command with systemctl and not an absolute path. This allows the OS to invoke the command regardless of the actual path to the binary.

I've also made the change for calls to nsupdate and curl.

Fixes [issue #94: Go-sbot service status query fails](https://git.coopcloud.tech/PeachCloud/peach-workspace/issues/94). Since `systemctl` may not always be found at `/usr/bin/systemctl` (depending on OS and user preferences), it's best to invoke the command with `systemctl` and not an absolute path. This allows the OS to invoke the command regardless of the actual path to the binary. I've also made the change for calls to `nsupdate` and `curl`.
glyph added 1 commit 2022-04-06 08:17:18 +00:00
replace absolute paths with relative paths for system command calls f1eaa07f7b
glyph added the
peach-lib
 label 2022-04-06 08:17:31 +00:00
glyph merged commit 169149d607 into main 2022-04-06 08:17:42 +00:00
glyph deleted branch fix_sys_cmd_paths 2022-04-06 08:17:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-lib
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#100
No description provided.
Delete Branch "fix_sys_cmd_paths"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?