PeachCloud/peach-workspace
3
2
Fork 1
Code Issues 17 Pull Requests 1 Projects Releases Wiki Activity

Update network args and remove structs #60

Merged
glyph merged 3 commits from update_network_args into main 2022-01-04 08:38:24 +00:00
Conversation 1 Commits 3 Files Changed 5 +33 -44
glyph commented 2022-01-03 09:59:42 +00:00
Owner
Copy Link
  • Remove the WiFi and Network structs
    • It's easier to simply pass in strings or string slices
    • I bumped into this friction while working on adding these methods to peach-jsonrpc-server
  • Replace String arguments with string slices
  • Update code usage examples
  • Bump the patch version of the crate: 0.4.1

CC: @notplants

- Remove the `WiFi` and `Network` structs - It's easier to simply pass in strings or string slices - I bumped into this friction while working on adding these methods to `peach-jsonrpc-server` - Replace `String` arguments with string slices - Update code usage examples - Bump the patch version of the crate: `0.4.1` CC: @notplants
glyph added the
peach-network
 label 2022-01-03 09:59:42 +00:00
glyph added 3 commits 2022-01-03 09:59:43 +00:00
bump patch version a05e67c22f
update code examples 4b0b2626a4
replace String with str and remove unnecessary structs 58f2ddde05
glyph requested review from notplants 2022-01-03 09:59:58 +00:00
notplants approved these changes 2022-01-03 21:28:23 +00:00
notplants left a comment
Owner
Copy Link

LGTM

LGTM
glyph merged commit 731bc1958b into main 2022-01-04 08:38:24 +00:00
glyph deleted branch update_network_args 2022-01-04 08:38:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
notplants
Labels
Clear labels
bug
Something is not working
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
maintenance
Pruning and weeding
peach-lib
peach-network
peach-oled
peach-stats
peach-web
question
More information is needed
refactor
Code rewrite
wontfix
This won't be fixed
No Label
peach-network
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cblgh glyph notplants
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PeachCloud/peach-workspace#60
No description provided.
Delete Branch "update_network_args"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?