diff --git a/pkg/app/app_test.go b/pkg/app/app_test.go index 2ac210a55..3f32e985b 100644 --- a/pkg/app/app_test.go +++ b/pkg/app/app_test.go @@ -3,8 +3,6 @@ package app_test import ( "encoding/json" "fmt" - "os" - "path" "reflect" "testing" @@ -12,77 +10,39 @@ import ( "coopcloud.tech/abra/pkg/config" "coopcloud.tech/abra/pkg/envfile" "coopcloud.tech/abra/pkg/recipe" + testPkg "coopcloud.tech/abra/pkg/test" "github.com/docker/docker/api/types/filters" "github.com/google/go-cmp/cmp" "github.com/stretchr/testify/assert" ) -var ( - TestFolder = os.ExpandEnv("$PWD/../../tests/resources/test_folder") - ValidAbraConf = os.ExpandEnv("$PWD/../../tests/resources/valid_abra_config") -) - -// make sure these are in alphabetical order -var ( - TFolders = []string{"folder1", "folder2"} - TFiles = []string{"bar.env", "foo.env"} -) - -var ( - AppName = "ecloud" - ServerName = "evil.corp" -) - -var ExpectedAppEnv = envfile.AppEnv{ - "DOMAIN": "ecloud.evil.corp", - "RECIPE": "ecloud", -} - -var ExpectedApp = appPkg.App{ - Name: AppName, - Recipe: ExpectedAppEnv["RECIPE"], - Domain: ExpectedAppEnv["DOMAIN"], - Env: ExpectedAppEnv, - Path: ExpectedAppFile.Path, - Server: ExpectedAppFile.Server, -} - -var ExpectedAppFile = appPkg.AppFile{ - Path: path.Join(ValidAbraConf, "servers", ServerName, AppName+".env"), - Server: ServerName, -} - -var ExpectedAppFiles = map[string]appPkg.AppFile{ - AppName: ExpectedAppFile, -} - func TestNewApp(t *testing.T) { - app, err := appPkg.NewApp(ExpectedAppEnv, AppName, ExpectedAppFile) + app, err := appPkg.NewApp(testPkg.ExpectedAppEnv, testPkg.AppName, testPkg.ExpectedAppFile) if err != nil { t.Fatal(err) } - if !reflect.DeepEqual(app, ExpectedApp) { - t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, ExpectedApp) + if !reflect.DeepEqual(app, testPkg.ExpectedApp) { + t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, testPkg.ExpectedApp) } } func TestReadAppEnvFile(t *testing.T) { - app, err := appPkg.ReadAppEnvFile(ExpectedAppFile, AppName) + app, err := appPkg.ReadAppEnvFile(testPkg.ExpectedAppFile, testPkg.AppName) if err != nil { t.Fatal(err) } - if !reflect.DeepEqual(app, ExpectedApp) { - t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, ExpectedApp) + if !reflect.DeepEqual(app, testPkg.ExpectedApp) { + t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, testPkg.ExpectedApp) } } func TestGetApp(t *testing.T) { - app, err := appPkg.GetApp(ExpectedAppFiles, AppName) + app, err := appPkg.GetApp(testPkg.ExpectedAppFiles, testPkg.AppName) if err != nil { t.Fatal(err) } - if !reflect.DeepEqual(app, ExpectedApp) { - t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, ExpectedApp) + if !reflect.DeepEqual(app, testPkg.ExpectedApp) { + t.Fatalf("did not get expected app type. Expected: %s; Got: %s", app, testPkg.ExpectedApp) } } diff --git a/pkg/envfile/envfile_test.go b/pkg/envfile/envfile_test.go index cd168a9f1..2ecd12a3f 100644 --- a/pkg/envfile/envfile_test.go +++ b/pkg/envfile/envfile_test.go @@ -2,7 +2,6 @@ package envfile_test import ( "fmt" - "os" "path" "reflect" "slices" @@ -13,59 +12,21 @@ import ( "coopcloud.tech/abra/pkg/config" "coopcloud.tech/abra/pkg/envfile" "coopcloud.tech/abra/pkg/recipe" + testPkg "coopcloud.tech/abra/pkg/test" ) -var ( - TestFolder = os.ExpandEnv("$PWD/../../tests/resources/test_folder") - ValidAbraConf = os.ExpandEnv("$PWD/../../tests/resources/valid_abra_config") -) - -// make sure these are in alphabetical order -var ( - TFolders = []string{"folder1", "folder2"} - TFiles = []string{"bar.env", "foo.env"} -) - -var ( - AppName = "ecloud" - ServerName = "evil.corp" -) - -var ExpectedAppEnv = envfile.AppEnv{ - "DOMAIN": "ecloud.evil.corp", - "RECIPE": "ecloud", -} - -var ExpectedApp = appPkg.App{ - Name: AppName, - Recipe: ExpectedAppEnv["RECIPE"], - Domain: ExpectedAppEnv["DOMAIN"], - Env: ExpectedAppEnv, - Path: ExpectedAppFile.Path, - Server: ExpectedAppFile.Server, -} - -var ExpectedAppFile = appPkg.AppFile{ - Path: path.Join(ValidAbraConf, "servers", ServerName, AppName+".env"), - Server: ServerName, -} - -var ExpectedAppFiles = map[string]appPkg.AppFile{ - AppName: ExpectedAppFile, -} - func TestGetAllFoldersInDirectory(t *testing.T) { - folders, err := config.GetAllFoldersInDirectory(TestFolder) + folders, err := config.GetAllFoldersInDirectory(testPkg.TestFolder) if err != nil { t.Fatal(err) } - if !reflect.DeepEqual(folders, TFolders) { - t.Fatalf("did not get expected folders. Expected: (%s), Got: (%s)", strings.Join(TFolders, ","), strings.Join(folders, ",")) + if !reflect.DeepEqual(folders, testPkg.TFolders) { + t.Fatalf("did not get expected folders. Expected: (%s), Got: (%s)", strings.Join(testPkg.TFolders, ","), strings.Join(folders, ",")) } } func TestGetAllFilesInDirectory(t *testing.T) { - files, err := config.GetAllFilesInDirectory(TestFolder) + files, err := config.GetAllFilesInDirectory(testPkg.TestFolder) if err != nil { t.Fatal(err) } @@ -73,21 +34,21 @@ func TestGetAllFilesInDirectory(t *testing.T) { for _, file := range files { fileNames = append(fileNames, file.Name()) } - if !reflect.DeepEqual(fileNames, TFiles) { - t.Fatalf("did not get expected files. Expected: (%s), Got: (%s)", strings.Join(TFiles, ","), strings.Join(fileNames, ",")) + if !reflect.DeepEqual(fileNames, testPkg.TFiles) { + t.Fatalf("did not get expected files. Expected: (%s), Got: (%s)", strings.Join(testPkg.TFiles, ","), strings.Join(fileNames, ",")) } } func TestReadEnv(t *testing.T) { - env, err := envfile.ReadEnv(ExpectedAppFile.Path) + env, err := envfile.ReadEnv(testPkg.ExpectedAppFile.Path) if err != nil { t.Fatal(err) } - if !reflect.DeepEqual(env, ExpectedAppEnv) { + if !reflect.DeepEqual(env, testPkg.ExpectedAppEnv) { t.Fatalf( "did not get expected application settings. Expected: DOMAIN=%s RECIPE=%s; Got: DOMAIN=%s RECIPE=%s", - ExpectedAppEnv["DOMAIN"], - ExpectedAppEnv["RECIPE"], + testPkg.ExpectedAppEnv["DOMAIN"], + testPkg.ExpectedAppEnv["RECIPE"], env["DOMAIN"], env["RECIPE"], ) diff --git a/pkg/test/test.go b/pkg/test/test.go index a5b8c1dd3..70bb1cae3 100644 --- a/pkg/test/test.go +++ b/pkg/test/test.go @@ -3,10 +3,52 @@ package test import ( "log" "os" + "path" + appPkg "coopcloud.tech/abra/pkg/app" + "coopcloud.tech/abra/pkg/envfile" "github.com/sirupsen/logrus" ) +var ( + TestFolder = os.ExpandEnv("$PWD/../../tests/resources/test_folder") + ValidAbraConf = os.ExpandEnv("$PWD/../../tests/resources/valid_abra_config") +) + +// make sure these are in alphabetical order +var ( + TFolders = []string{"folder1", "folder2"} + TFiles = []string{"bar.env", "foo.env"} +) + +var ( + AppName = "ecloud" + ServerName = "evil.corp" +) + +var ExpectedAppEnv = envfile.AppEnv{ + "DOMAIN": "ecloud.evil.corp", + "RECIPE": "ecloud", +} + +var ExpectedApp = appPkg.App{ + Name: AppName, + Recipe: ExpectedAppEnv["RECIPE"], + Domain: ExpectedAppEnv["DOMAIN"], + Env: ExpectedAppEnv, + Path: ExpectedAppFile.Path, + Server: ExpectedAppFile.Server, +} + +var ExpectedAppFile = appPkg.AppFile{ + Path: path.Join(ValidAbraConf, "servers", ServerName, AppName+".env"), + Server: ServerName, +} + +var ExpectedAppFiles = map[string]appPkg.AppFile{ + AppName: ExpectedAppFile, +} + // RmServerAppRecipe deletes the test server / app / recipe. func RmServerAppRecipe() { testAppLink := os.ExpandEnv("$HOME/.abra/servers/foo.com")