From 11c4651a3bb4a5890c215916fae1d3bf5e36b9bd Mon Sep 17 00:00:00 2001 From: knoflook Date: Tue, 5 Oct 2021 11:39:05 +0200 Subject: [PATCH] fix: don't crash when there is a more serious upgrade available --- cli/recipe/upgrade.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cli/recipe/upgrade.go b/cli/recipe/upgrade.go index ad2f8e9e7..59613d6cc 100644 --- a/cli/recipe/upgrade.go +++ b/cli/recipe/upgrade.go @@ -130,6 +130,10 @@ is up to the end-user to decide. break } } + if upgradeTag == "" { + logrus.Warnf("not upgrading from '%s' to '%s' for '%s', because the upgrade type is more serious than what user wants.", tag.String(), compatible[0].String(), image) + continue + } } else { msg := fmt.Sprintf("upgrade to which tag? (service: %s, tag: %s)", service.Name, tag) if !tagcmp.IsParsable(img.(reference.NamedTagged).Tag()) { @@ -154,7 +158,7 @@ is up to the end-user to decide. if err := recipe.UpdateTag(image, upgradeTag); err != nil { logrus.Fatal(err) } - logrus.Infof("tag updated from '%s' to '%s' for '%s'", tag.String(), upgradeTag, recipe.Name) + logrus.Infof("tag upgraded from '%s' to '%s' for '%s'", tag.String(), upgradeTag, image) } return nil