fix: filtering requires case-by-case handling

See https://github.com/moby/moby/issues/32985.
This commit is contained in:
2022-03-30 16:11:52 +02:00
parent e8e41850b5
commit 323f4467c8
6 changed files with 35 additions and 10 deletions

View File

@ -30,7 +30,7 @@ var logOpts = types.ContainerLogsOptions{
// stackLogs lists logs for all stack services
func stackLogs(c *cli.Context, app config.App, client *dockerClient.Client) {
filters, err := app.Filters()
filters, err := app.Filters(true, false)
if err != nil {
logrus.Fatal(err)
}

View File

@ -66,7 +66,7 @@ var appPsCommand = cli.Command{
// showPSOutput renders ps output.
func showPSOutput(c *cli.Context, app config.App, cl *dockerClient.Client) {
filters, err := app.Filters()
filters, err := app.Filters(true, true)
if err != nil {
logrus.Fatal(err)
}

View File

@ -65,7 +65,7 @@ var appRemoveCommand = cli.Command{
logrus.Fatalf("%s is still deployed. Run \"abra app undeploy %s\"", app.Name, app.Name)
}
fs, err := app.Filters()
fs, err := app.Filters(false, false)
if err != nil {
logrus.Fatal(err)
}
@ -114,6 +114,11 @@ var appRemoveCommand = cli.Command{
logrus.Info("no secrets to remove")
}
fs, err = app.Filters(false, true)
if err != nil {
logrus.Fatal(err)
}
volumeListOKBody, err := cl.VolumeList(context.Background(), fs)
volumeList := volumeListOKBody.Volumes
if err != nil {

View File

@ -216,7 +216,7 @@ Example:
logrus.Fatal(err)
}
filters, err := app.Filters()
filters, err := app.Filters(false, false)
if err != nil {
logrus.Fatal(err)
}
@ -293,7 +293,7 @@ var appSecretLsCommand = cli.Command{
logrus.Fatal(err)
}
filters, err := app.Filters()
filters, err := app.Filters(false, false)
if err != nil {
logrus.Fatal(err)
}

View File

@ -26,7 +26,7 @@ var appVolumeListCommand = cli.Command{
Action: func(c *cli.Context) error {
app := internal.ValidateApp(c)
filters, err := app.Filters()
filters, err := app.Filters(false, true)
if err != nil {
logrus.Fatal(err)
}
@ -80,7 +80,7 @@ Passing "--force/-f" will select all volumes for removal. Be careful.
Action: func(c *cli.Context) error {
app := internal.ValidateApp(c)
filters, err := app.Filters()
filters, err := app.Filters(false, true)
if err != nil {
logrus.Fatal(err)
}