fix: avoid overwriting non version env vars

See coop-cloud/organising#630

pkg/envfile/envfile_test.go

@@ -11,6 +11,7 @@ import (
 	"coopcloud.tech/abra/pkg/envfile"
 	"coopcloud.tech/abra/pkg/recipe"
 	testPkg "coopcloud.tech/abra/pkg/test"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestGetAllFoldersInDirectory(t *testing.T) {
@@ -43,13 +44,7 @@ func TestReadEnv(t *testing.T) {
 		t.Fatal(err)
 	}
 	if !reflect.DeepEqual(env, testPkg.ExpectedAppEnv) {
-		t.Fatalf(
-			"did not get expected application settings. Expected: DOMAIN=%s RECIPE=%s; Got: DOMAIN=%s RECIPE=%s",
-			testPkg.ExpectedAppEnv["DOMAIN"],
-			testPkg.ExpectedAppEnv["RECIPE"],
-			env["DOMAIN"],
-			env["RECIPE"],
-		)
+		t.Fatal("did not get expected application settings")
 	}
 }
 
@@ -228,3 +223,21 @@ func TestEnvVarModifiersIncluded(t *testing.T) {
 		}
 	}
 }
+
+func TestNoOverwriteNonVersionEnvVars(t *testing.T) {
+	app, err := appPkg.GetApp(testPkg.ExpectedAppFiles, testPkg.AppName)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	if err := app.WriteRecipeVersion("1.3.12", true); err != nil {
+		t.Fatal(err)
+	}
+
+	app, err = appPkg.GetApp(testPkg.ExpectedAppFiles, testPkg.AppName)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	assert.NotEqual(t, app.Env["SMTP_AUTHTYPE"], "login:1.3.12")
+}