refactor!: cobra migrate

cli/app/upgrade.go

@@ -15,37 +15,50 @@ import (
 	stack "coopcloud.tech/abra/pkg/upstream/stack"
 	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
-	"github.com/urfave/cli/v3"
+	"github.com/spf13/cobra"
 )
 
-var appUpgradeCommand = cli.Command{
-	Name:      "upgrade",
-	Aliases:   []string{"up"},
-	Usage:     "Upgrade an app",
-	UsageText: "abra app upgrade <domain> [<version>] [options]",
-	Flags: []cli.Flag{
-		internal.ForceFlag,
-		internal.NoDomainChecksFlag,
-		internal.DontWaitConvergeFlag,
-		internal.ReleaseNotesFlag,
-	},
-	Before: internal.SubCommandBefore,
-	Description: `Upgrade an app.
+var AppUpgradeCommand = &cobra.Command{
+	Use:     "upgrade <app> [version] [flags]",
+	Aliases: []string{"up"},
+	Short:   "Upgrade an app",
+	Long: `Upgrade an app.
 
 Unlike "deploy", chaos operations are not supported here. Only recipe versions
-are supported values for "[<version>]".
+are supported values for "[version]".
 
 An upgrade can be destructive, please ensure you have a copy of your app data
 beforehand.`,
-	HideHelp:      true,
-	ShellComplete: autocomplete.AppNameComplete,
-	Action: func(ctx context.Context, cmd *cli.Command) error {
+	Args: cobra.RangeArgs(1, 2),
+	ValidArgsFunction: func(
+		cmd *cobra.Command,
+		args []string,
+		toComplete string) ([]string, cobra.ShellCompDirective) {
+		switch l := len(args); l {
+		case 0:
+			return autocomplete.AppNameComplete()
+		case 1:
+			app, err := appPkg.Get(args[0])
+			if err != nil {
+				log.Debugf("autocomplete failed: %s", err)
+				return nil, cobra.ShellCompDirectiveDefault
+			}
+			return autocomplete.RecipeVersionComplete(app.Recipe.Name)
+		default:
+			return nil, cobra.ShellCompDirectiveError
+		}
+	},
+	Run: func(cmd *cobra.Command, args []string) {
 		var warnMessages []string
 
-		app := internal.ValidateApp(cmd)
+		app := internal.ValidateApp(args)
 		stackName := app.StackName()
 
-		specificVersion := cmd.Args().Get(1)
+		var specificVersion string
+		if len(args) == 2 {
+			specificVersion = args[1]
+		}
+
 		if specificVersion != "" {
 			log.Debugf("overriding env file version (%s) with %s", app.Recipe.Version, specificVersion)
 			app.Recipe.Version = specificVersion
@@ -129,7 +142,7 @@ beforehand.`,
 
 			if len(availableUpgrades) == 0 && !internal.Force {
 				log.Info("no available upgrades")
-				return nil
+				return
 			}
 		}
 
@@ -150,7 +163,7 @@ beforehand.`,
 				}
 
 				if err := survey.AskOne(prompt, &chosenUpgrade); err != nil {
-					return err
+					return
 				}
 			}
 		}
@@ -177,7 +190,7 @@ beforehand.`,
 				if parsedVersion.IsGreaterThan(parsedDeployedVersion) && parsedVersion.IsLessThan(parsedChosenUpgrade) {
 					note, err := app.Recipe.GetReleaseNotes(version)
 					if err != nil {
-						return err
+						log.Fatal(err)
 					}
 					if note != "" {
 						releaseNotes += fmt.Sprintf("%s\n", note)
@@ -236,10 +249,10 @@ beforehand.`,
 			}
 		}
 
-		if internal.ReleaseNotes {
+		if showReleaseNotes {
 			fmt.Println()
 			fmt.Print(releaseNotes)
-			return nil
+			return
 		}
 
 		chaosVersion := config.CHAOS_DEFAULT
@@ -281,7 +294,42 @@ beforehand.`,
 		if err := app.WriteRecipeVersion(app.Recipe.Version, false); err != nil {
 			log.Fatalf("writing new recipe version in env file: %s", err)
 		}
-
-		return nil
 	},
 }
+
+var (
+	showReleaseNotes bool
+)
+
+func init() {
+	AppUpgradeCommand.Flags().BoolVarP(
+		&internal.Force,
+		"force",
+		"f",
+		false,
+		"perform action without further prompt",
+	)
+
+	AppUpgradeCommand.Flags().BoolVarP(
+		&internal.NoDomainChecks,
+		"no-domain-checks",
+		"D",
+		false,
+		"disable public DNS checks",
+	)
+
+	AppUpgradeCommand.Flags().BoolVarP(
+		&internal.DontWaitConverge, "no-converge-checks",
+		"c",
+		false,
+		"do not wait for converge logic checks",
+	)
+
+	AppUpgradeCommand.Flags().BoolVarP(
+		&showReleaseNotes,
+		"releasenotes",
+		"r",
+		false,
+		"only show release notes",
+	)
+}