From deb7d211589f7a02624229dc8a0525c068412be8 Mon Sep 17 00:00:00 2001
From: decentral1se <lukewm@riseup.net>
Date: Tue, 12 Oct 2021 00:56:52 +0200
Subject: [PATCH] fix: dont loop over dead tags

Closes https://git.coopcloud.tech/coop-cloud/organising/issues/195.
---
 cli/recipe/release.go | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/cli/recipe/release.go b/cli/recipe/release.go
index 2b29ee423..ba035fda9 100644
--- a/cli/recipe/release.go
+++ b/cli/recipe/release.go
@@ -13,7 +13,7 @@ import (
 	"coopcloud.tech/tagcmp"
 	"github.com/AlecAivazis/survey/v2"
 	"github.com/go-git/go-git/v5"
-	"github.com/go-git/go-git/v5/plumbing/object"
+	"github.com/go-git/go-git/v5/plumbing"
 	"github.com/sirupsen/logrus"
 	"github.com/urfave/cli/v2"
 )
@@ -209,14 +209,18 @@ or a rollback of an app.
 
 		// get the latest tag with its hash, name etc
 		var lastGitTag tagcmp.Tag
-		iter, err := repo.TagObjects()
+		iter, err := repo.Tags()
 		if err != nil {
 			logrus.Fatal(err)
 		}
-		if err := iter.ForEach(func(obj *object.Tag) error {
+		if err := iter.ForEach(func(ref *plumbing.Reference) error {
+			obj, err := repo.TagObject(ref.Hash())
+			if err != nil {
+				return err
+			}
 			tagcmpTag, err := tagcmp.Parse(obj.Name)
 			if err != nil {
-				logrus.Fatal(err)
+				return err
 			}
 			if (lastGitTag == tagcmp.Tag{}) {
 				lastGitTag = tagcmpTag
@@ -224,7 +228,6 @@ or a rollback of an app.
 				lastGitTag = tagcmpTag
 			}
 			return nil
-
 		}); err != nil {
 			logrus.Fatal(err)
 		}