coop-cloud-chaos-patchs/compy
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Honor Accept-Encoding header in gzip transcoder

Browse Source 
This avoids sending compressed data to clients which do not support
it.
This commit is contained in:
Andrew Gaul
2017-01-14 15:20:14 -08:00
parent cac3b84a5d
commit 11a40b5051
7 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
transcoder/gif.go
View File

@ -3,11 +3,12 @@ package transcoder
import (
"github.com/barnacs/compy/proxy"
"image/gif"
"net/http"
)
type Gif struct{}
func (t *Gif) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (t *Gif) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
img, err := gif.Decode(r)
if err != nil {
return err

17
transcoder/gzip.go
View File

@ -3,6 +3,8 @@ package transcoder
import (
"compress/gzip"
"github.com/barnacs/compy/proxy"
"net/http"
"strings"
)
type Gzip struct {
@ -10,7 +12,7 @@ type Gzip struct {
SkipGzipped bool
}
func (t *Gzip) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (t *Gzip) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
if t.decompress(r) {
gzr, err := gzip.NewReader(r.Reader)
if err != nil {
@ -21,13 +23,22 @@ func (t *Gzip) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error
r.Header().Del("Content-Encoding")
w.Header().Del("Content-Encoding")
}
if compress(r) {
shouldGzip := false
for _, v := range strings.Split(headers.Get("Accept-Encoding"), ", ") {
if strings.SplitN(v, ";", 2)[0] == "gzip" {
shouldGzip = true
break
}
}
if shouldGzip && compress(r) {
gzw := gzip.NewWriter(w.Writer)
defer gzw.Flush()
w.Writer = gzw
w.Header().Set("Content-Encoding", "gzip")
}
return t.Transcoder.Transcode(w, r)
return t.Transcoder.Transcode(w, r, headers)
}
func (t *Gzip) decompress(r *proxy.ResponseReader) bool {

3
transcoder/identity.go
View File

@ -2,10 +2,11 @@ package transcoder
import (
"github.com/barnacs/compy/proxy"
"net/http"
)
type Identity struct{}
func (i *Identity) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (i *Identity) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
return w.ReadFrom(r)
}

3
transcoder/jpeg.go
View File

@ -3,6 +3,7 @@ package transcoder
import (
"github.com/barnacs/compy/proxy"
"github.com/pixiv/go-libjpeg/jpeg"
"net/http"
)
type Jpeg struct {
@ -20,7 +21,7 @@ func NewJpeg(quality int) *Jpeg {
}
}
func (t *Jpeg) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (t *Jpeg) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
img, err := jpeg.Decode(r, t.decOptions)
if err != nil {
return err

3
transcoder/minify.go
View File

@ -6,6 +6,7 @@ import (
"github.com/tdewolff/minify/css"
"github.com/tdewolff/minify/html"
"github.com/tdewolff/minify/js"
"net/http"
)
type Minifier struct {
@ -24,6 +25,6 @@ func NewMinifier() *Minifier {
}
}
func (t *Minifier) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (t *Minifier) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
return t.m.Minify(r.ContentType(), w, r)
}

3
transcoder/png.go
View File

@ -3,11 +3,12 @@ package transcoder
import (
"github.com/barnacs/compy/proxy"
"image/png"
"net/http"
)
type Png struct{}
func (t *Png) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader) error {
func (t *Png) Transcode(w *proxy.ResponseWriter, r *proxy.ResponseReader, headers http.Header) error {
img, err := png.Decode(r)
if err != nil {
return err