went a bit too far with search+replace
This commit is contained in:
parent
4d3610e2fb
commit
580830be76
|
@ -141,7 +141,7 @@ func (ts *testSession) startGoServer(
|
|||
ts.done.Go(func() error {
|
||||
err := srv.Network.Serve(ts.ctx)
|
||||
// if the muxrpc protocol fucks up by e.g. unpacking body data into a header, this type of error will be surfaced here and look scary in the test output
|
||||
// example: https://github.com/ssb-ngi-pointer/go-ssb-room/v2/pull/85#issuecomment-801106687
|
||||
// example: https://github.com/ssb-ngi-pointer/go-ssb-room/pull/85#issuecomment-801106687
|
||||
if err != nil && !errors.Is(err, context.Canceled) {
|
||||
err = fmt.Errorf("go server exited: %w", err)
|
||||
ts.t.Log(err)
|
||||
|
|
|
@ -134,7 +134,7 @@ func TestModernJSClient(t *testing.T) {
|
|||
}
|
||||
|
||||
// found a nasty `throw err` in the JS stack around pull.drain. lets make sure it stays gone
|
||||
// https://github.com/ssb-ngi-pointer/go-ssb-room/v2/issues/190
|
||||
// https://github.com/ssb-ngi-pointer/go-ssb-room/issues/190
|
||||
func TestClientSurvivesShutdown(t *testing.T) {
|
||||
r := require.New(t)
|
||||
|
||||
|
|
|
@ -34,7 +34,7 @@ func TestInviteShowAcceptForm(t *testing.T) {
|
|||
|
||||
// request the form
|
||||
doc, resp := ts.Client.GetHTML(acceptURL404)
|
||||
// 500 until https://github.com/ssb-ngi-pointer/go-ssb-room/v2/issues/66 is fixed
|
||||
// 500 until https://github.com/ssb-ngi-pointer/go-ssb-room/issues/66 is fixed
|
||||
a.Equal(http.StatusInternalServerError, resp.Code)
|
||||
|
||||
// check database calls
|
||||
|
|
|
@ -48,8 +48,8 @@ func NewURLTo(appRouter *mux.Router, netInfo network.ServerEndpointDetails) URLM
|
|||
return func(routeName string, ps ...interface{}) *url.URL {
|
||||
route := appRouter.Get(routeName)
|
||||
if route == nil {
|
||||
// TODO: https://github.com/ssb-ngi-pointer/go-ssb-room/v2/issues/35 for a
|
||||
// for reference, see https://github.com/ssb-ngi-pointer/go-ssb-room/v2/pull/64
|
||||
// TODO: https://github.com/ssb-ngi-pointer/go-ssb-room/issues/35 for a
|
||||
// for reference, see https://github.com/ssb-ngi-pointer/go-ssb-room/pull/64
|
||||
// level.Warn(l).Log("msg", "no such route", "route", routeName, "params", fmt.Sprintf("%v", ps))
|
||||
return &url.URL{}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue