From 2ca57fc7cf030135b6e6638acabe7064e9fbcdaa Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sun, 13 Jun 2021 17:47:17 -0700 Subject: [PATCH] fix: 3 locations with return undefined (not compatible with React 17) --- app/components/Analytics.js | 4 +++- app/menus/NewDocumentMenu.js | 2 +- app/menus/NewTemplateMenu.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/components/Analytics.js b/app/components/Analytics.js index 78aebed6..ef9e0f15 100644 --- a/app/components/Analytics.js +++ b/app/components/Analytics.js @@ -9,7 +9,9 @@ type Props = { export default class Analytics extends React.Component { componentDidMount() { - if (!env.GOOGLE_ANALYTICS_ID) return; + if (!env.GOOGLE_ANALYTICS_ID) { + return null; + } // standard Google Analytics script window.ga = diff --git a/app/menus/NewDocumentMenu.js b/app/menus/NewDocumentMenu.js index ad1cb7bc..2f1080b2 100644 --- a/app/menus/NewDocumentMenu.js +++ b/app/menus/NewDocumentMenu.js @@ -25,7 +25,7 @@ function NewDocumentMenu() { const can = policies.abilities(team.id); if (!can.createDocument) { - return; + return null; } if (singleCollection) { diff --git a/app/menus/NewTemplateMenu.js b/app/menus/NewTemplateMenu.js index ba8c8fd3..19432090 100644 --- a/app/menus/NewTemplateMenu.js +++ b/app/menus/NewTemplateMenu.js @@ -23,7 +23,7 @@ function NewTemplateMenu() { const can = policies.abilities(team.id); if (!can.createDocument) { - return; + return null; } return (