coop-cloud-chaos-patchs/outline
coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: miro - use the incoming domain to ensure access to logged in boards works (#1756)

Browse Source
This commit is contained in:
Clifton Cunningham 2020-12-30 18:35:18 +01:00 committed by GitHub
parent d4bb04e921
commit 40bd9aed0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/embeds/Miro.js
View File

@ -2,7 +2,7 @@
import * as React from "react"; import * as React from "react";
import Frame from "./components/Frame"; import Frame from "./components/Frame";
const URL_REGEX = /^https:\/\/(?:realtimeboard|miro).com\/app\/board\/(.*)$/; const URL_REGEX = /^https:\/\/(realtimeboard|miro).com\/app\/board\/(.*)$/;
type Props = {| type Props = {|
attrs: {| attrs: {|
@ -16,13 +16,15 @@ export default class RealtimeBoard extends React.Component<Props> {
render() { render() {
const { matches } = this.props.attrs; const { matches } = this.props.attrs;
const boardId = matches[1]; const domain = matches[1];
const boardId = matches[2];
const titleName = domain === "realtimeboard" ? "RealtimeBoard" : "Miro";
return ( return (
<Frame <Frame
{...this.props} {...this.props}
src={`https://realtimeboard.com/app/embed/${boardId}`} src={`https://${domain}.com/app/embed/${boardId}`}
title={`RealtimeBoard (${boardId})`} title={`${titleName} (${boardId})`}
/> />
); );
} }

6
app/embeds/Miro.test.js
View File

@ -13,6 +13,12 @@ describe("Miro", () => {
expect("https://miro.com/app/board/o9J_k0fwiss=".match(match)).toBeTruthy(); expect("https://miro.com/app/board/o9J_k0fwiss=".match(match)).toBeTruthy();
}); });
test("to extract the domain as part of the match for later use", () => {
expect(
"https://realtimeboard.com/app/board/o9J_k0fwiss=".match(match)[1]
).toBe("realtimeboard");
});
test("to not be enabled elsewhere", () => { test("to not be enabled elsewhere", () => {
expect("https://miro.com".match(match)).toBe(null); expect("https://miro.com".match(match)).toBe(null);
expect("https://realtimeboard.com".match(match)).toBe(null); expect("https://realtimeboard.com".match(match)).toBe(null);