coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: 'Post to channel' functionality does not work unless Slack SSO used (#2099)

Browse Source 
* fix: 'Post to channel' functionality does not work unless Slack SSO used

* test: And this is why we have tests
This commit is contained in:
Tom Moor
2021-05-01 16:35:00 -07:00
committed by GitHub
parent 77d6adb73b
commit 49ffcda8e0
1 changed files with 13 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
server/api/hooks.js
View File

@ -8,7 +8,6 @@ import {
Document, Document,
User, User,
Team, Team,
Collection,
SearchQuery, SearchQuery,
Integration, Integration,
IntegrationAuthentication, IntegrationAuthentication,
@ -79,49 +78,27 @@ router.post("hooks.interactive", async (ctx) => {
throw new AuthenticationError("Invalid verification token"); throw new AuthenticationError("Invalid verification token");
} }
const authProvider = await AuthenticationProvider.findOne({ // we find the document based on the users teamId to ensure access
where: { const document = await Document.scope("withCollection").findByPk(
name: "slack", data.callback_id
providerId: data.team.id, );
}, if (!document) {
include: [ throw new InvalidRequestError("Invalid callback_id");
{
model: Team,
as: "team",
required: true,
},
],
});
if (!authProvider) {
ctx.body = {
text:
"Sorry, we couldn’t find an integration for your team. Head to your Outline settings to set one up.",
response_type: "ephemeral",
replace_original: false,
};
return;
} }
const { team } = authProvider; const team = await Team.findByPk(document.teamId);
// we find the document based on the users teamId to ensure access
const document = await Document.findOne({
where: {
id: data.callback_id,
teamId: team.id,
},
});
if (!document) throw new InvalidRequestError("Invalid document");
const collection = await Collection.findByPk(document.collectionId);
// respond with a public message that will be posted in the original channel // respond with a public message that will be posted in the original channel
ctx.body = { ctx.body = {
response_type: "in_channel", response_type: "in_channel",
replace_original: false, replace_original: false,
attachments: [ attachments: [
presentSlackAttachment(document, collection, team, document.getSummary()), presentSlackAttachment(
document,
document.collection,
team,
document.getSummary()
),
], ],
}; };
}); });