From 4c96f1ead0a9bbe1e9223b5521bfab8385c075a1 Mon Sep 17 00:00:00 2001
From: Jori Lallo <jtlallo@gmail.com>
Date: Sun, 9 Jul 2017 20:27:06 -0700
Subject: [PATCH] Improve concurrency and reduce one DB call from document
 saving

---
 server/api/documents.js | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/server/api/documents.js b/server/api/documents.js
index e482c79d..2d19612b 100644
--- a/server/api/documents.js
+++ b/server/api/documents.js
@@ -208,7 +208,10 @@ router.post('documents.update', auth(), async ctx => {
   ctx.assertPresent(title || text, 'title or text is required');
 
   const user = ctx.state.user;
-  const document = await Document.findById(id);
+  const document = await Document.findById(id, {
+    include: ['collection'],
+  });
+  const collection = document.collection;
 
   if (!document || document.teamId !== user.teamId) throw httpErrors.NotFound();
 
@@ -216,16 +219,18 @@ router.post('documents.update', auth(), async ctx => {
   if (title) document.title = title;
   if (text) document.text = text;
   document.lastModifiedById = user.id;
-  await document.save();
 
-  const collection = await Collection.findById(document.atlasId);
-  if (collection.type === 'atlas') {
-    await collection.updateDocument(document);
-    document.collection = collection;
-  }
+  const [updatedDocument, updatedCollection] = await Promise.all([
+    document.save(),
+    collection.type === 'atlas'
+      ? await collection.updateDocument(document)
+      : Promise.resolve(),
+  ]);
+
+  updatedDocument.collection = updatedCollection;
 
   ctx.body = {
-    data: await presentDocument(ctx, document),
+    data: await presentDocument(ctx, updatedDocument),
   };
 });