coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Handle non-existent shareId

Browse Source
This commit is contained in:
Tom Moor
2018-05-26 11:23:21 -07:00
parent 0d7c943bcd
commit 6662e2666d
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/api/documents.js
View File

@ -174,6 +174,9 @@ router.post('documents.info', auth({ required: false }), async ctx => {
}, },
], ],
}); });
if (!share) {
throw new InvalidRequestError('Document could not be found for shareId');
}
document = share.document; document = share.document;
} else { } else {
document = await Document.findById(id); document = await Document.findById(id);

7
server/api/documents.test.js
View File

@ -73,6 +73,13 @@ describe('#documents.info', async () => {
expect(body.data.createdBy.id).toEqual(user.id); expect(body.data.createdBy.id).toEqual(user.id);
expect(body.data.updatedBy.id).toEqual(user.id); expect(body.data.updatedBy.id).toEqual(user.id);
}); });
it('should require a valid shareId', async () => {
const res = await server.post('/api/documents.info', {
body: { shareId: 123 },
});
expect(res.status).toEqual(400);
});
}); });
describe('#documents.list', async () => { describe('#documents.list', async () => {