coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: Add application/octet-stream as a valid mimetype for docx uploads (#2105)

Browse Source 
* fix: Add application/octet-stream as a valid mimetype for docx uploads

* fix: Include application/octet-stream in frontend filter
fix: Add file size and file type guards

* Validate .docx extension in files with application/octet-stream mimetype

* refactor: Move MAXIMUM_IMPORT_SIZE to an optional environment config
fix: Add file size check on server too

Co-authored-by: Saumya Pandey <sp160899@gmail.com>
This commit is contained in:
Tom Moor
2021-05-05 18:48:37 -07:00
committed by GitHub
parent 6ef8d9ddb3
commit 69802cc985
7 changed files with 100 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/api/documents.js
View File

@ -5,6 +5,7 @@ import { subtractDate } from "../../shared/utils/date";
import documentCreator from "../commands/documentCreator";
import documentImporter from "../commands/documentImporter";
import documentMover from "../commands/documentMover";
import env from "../env";
import {
NotFoundError,
InvalidRequestError,
@ -1179,6 +1180,10 @@ router.post("documents.import", auth(), async (ctx) => {
const file: any = Object.values(ctx.request.files)[0];
ctx.assertPresent(file, "file is required");
if (file.size > env.MAXIMUM_IMPORT_SIZE) {
throw new InvalidRequestError("The selected file was too large to import");
}
ctx.assertUuid(collectionId, "collectionId must be an uuid");
if (parentDocumentId) {
ctx.assertUuid(parentDocumentId, "parentDocumentId must be an uuid");