coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: Server error when attempting to update team with identical details to previous

Browse Source
This commit is contained in:
Tom Moor
2020-12-04 08:01:22 -08:00
parent aa6fc45097
commit 6c1ecde4e7
2 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
server/api/team.js
View File

@ -37,17 +37,19 @@ router.post("team.update", auth(), async (ctx) => {
await team.save(); await team.save();
for (const change of changes) { if (changes) {
data[change] = team[change]; for (const change of changes) {
} data[change] = team[change];
}
await Event.create({ await Event.create({
name: "teams.update", name: "teams.update",
actorId: user.id, actorId: user.id,
teamId: user.teamId, teamId: user.teamId,
data, data,
ip: ctx.request.ip, ip: ctx.request.ip,
}); });
}
ctx.body = { ctx.body = {
data: presentTeam(team), data: presentTeam(team),

11
server/api/team.test.js
View File

@ -21,6 +21,17 @@ describe("#team.update", () => {
expect(body.data.name).toEqual("New name"); expect(body.data.name).toEqual("New name");
}); });
it("should allow identical team details", async () => {
const { admin, team } = await seed();
const res = await server.post("/api/team.update", {
body: { token: admin.getJwtToken(), name: team.name },
});
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.data.name).toEqual(team.name);
});
it("should require admin", async () => { it("should require admin", async () => {
const { user } = await seed(); const { user } = await seed();
const res = await server.post("/api/team.update", { const res = await server.post("/api/team.update", {