fix: Server error when listing memberships for group with deleted user (#1288)

* fix: Server error when listing memberships for group with deleted user * PR feedback: Filter before slice
2020-05-28 08:21:22 -07:00
parent ca1ba277ad
commit 7d55b7f69b
2 changed files with 36 additions and 1 deletions
--- a/server/api/groups.js
+++ b/server/api/groups.js
@ -40,7 +40,11 @@ router.post('groups.list', auth(), pagination(), async ctx => {
    data: {
      groups: groups.map(presentGroup),
      groupMemberships: groups
-        .map(g => g.groupMemberships.slice(0, MAX_AVATAR_DISPLAY))
+        .map(g =>
+          g.groupMemberships
+            .filter(membership => !!membership.user)
+            .slice(0, MAX_AVATAR_DISPLAY)
+        )
        .flat()
        .map(presentGroupMembership),
    },