coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat: Normalized server logging (#2567)

Browse Source 
* feat: Normalize logging

* Remove scattered console.error + Sentry.captureException

* Remove mention of debug

* cleanup dev output

* Edge cases, docs

* Refactor: Move logger, metrics, sentry under 'logging' folder.
Trying to reduce the amount of things under generic 'utils'

* cleanup, last few console calls
This commit is contained in:
Tom Moor
2021-09-14 18:04:35 -07:00
committed by GitHub
parent 6c605cf720
commit 83a61b87ed
36 changed files with 508 additions and 264 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/middlewares/passport.js
View File

@ -2,6 +2,7 @@
import passport from "@outlinewiki/koa-passport";
import { type Context } from "koa";
import type { AccountProvisionerResult } from "../commands/accountProvisioner";
import Logger from "../logging/logger";
import { signIn } from "../utils/authentication";
export default function createMiddleware(providerName: string) {
@ -11,7 +12,7 @@ export default function createMiddleware(providerName: string) {
{ session: false },
async (err, user, result: AccountProvisionerResult) => {
if (err) {
console.error(err);
Logger.error("Error during authentication", err);
if (err.id) {
const notice = err.id.replace(/_/g, "-");
@ -36,7 +37,10 @@ export default function createMiddleware(providerName: string) {
// Correlation ID, Timestamp in these two query string parameters.
const { error, error_description } = ctx.request.query;
if (error && error_description) {
console.error(error_description);
Logger.error(
"Error from Azure during authentication",
new Error(error_description)
);
// Display only the descriptive message to the user, log the rest
const description = error_description.split("Trace ID")[0];