coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: Remove collaborators from documents.list response (#2039)

Browse Source 
* fix: Remove unused, unperformant query

* lint

* collaborators -> collaboratorIds
This commit is contained in:
Tom Moor
2021-04-15 22:49:16 -07:00
committed by GitHub
parent c5401a467d
commit 940ad8479e
2 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/Document.js
View File

@ -24,7 +24,7 @@ export default class Document extends BaseModel {
@observable lastViewedAt: ?string; @observable lastViewedAt: ?string;
store: DocumentsStore; store: DocumentsStore;
collaborators: User[]; collaboratorIds: string[];
collectionId: string; collectionId: string;
createdAt: string; createdAt: string;
createdBy: User; createdBy: User;

15
server/presenters/document.js
View File

@ -1,6 +1,5 @@
// @flow // @flow
import { takeRight } from "lodash"; import { Attachment, Document } from "../models";
import { Attachment, Document, User } from "../models";
import parseAttachmentIds from "../utils/parseAttachmentIds"; import parseAttachmentIds from "../utils/parseAttachmentIds";
import { getSignedImageUrl } from "../utils/s3"; import { getSignedImageUrl } from "../utils/s3";
import presentUser from "./user"; import presentUser from "./user";
@ -53,7 +52,7 @@ export default async function present(document: Document, options: ?Options) {
teamId: document.teamId, teamId: document.teamId,
template: document.template, template: document.template,
templateId: document.templateId, templateId: document.templateId,
collaborators: [], collaboratorIds: [],
starred: document.starred ? !!document.starred.length : undefined, starred: document.starred ? !!document.starred.length : undefined,
revision: document.revisionCount, revision: document.revisionCount,
pinned: undefined, pinned: undefined,
@ -72,15 +71,7 @@ export default async function present(document: Document, options: ?Options) {
data.parentDocumentId = document.parentDocumentId; data.parentDocumentId = document.parentDocumentId;
data.createdBy = presentUser(document.createdBy); data.createdBy = presentUser(document.createdBy);
data.updatedBy = presentUser(document.updatedBy); data.updatedBy = presentUser(document.updatedBy);
data.collaboratorIds = document.collaboratorIds;
// TODO: This could be further optimized
data.collaborators = (
await User.findAll({
where: {
id: takeRight(document.collaboratorIds, 10) || [],
},
})
).map(presentUser);
} }
return data; return data;