coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: Move collection index validation logic to a context assert function (#2116)

Browse Source 
* Abstract validation logic for readability

* Add index validation in collections.move

* Add tests
This commit is contained in:
Saumya Pandey
2021-05-10 11:00:37 +05:30
committed by GitHub
parent 721e7466e6
commit 985f0da674
4 changed files with 35 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/api/collections.js
View File

@ -67,12 +67,10 @@ router.post("collections.create", auth(), async (ctx) => {
});
if (index) {
const allowedASCII = new RegExp(/^[\x21-\x7E]+$/);
if (!allowedASCII.test(index)) {
throw new ValidationError(
"Index characters must be between x21 to x7E ASCII"
);
}
ctx.assertIndexCharacters(
index,
"Index characters must be between x21 to x7E ASCII"
);
} else {
index = fractionalIndex(
null,
@ -664,6 +662,10 @@ router.post("collections.move", auth(), async (ctx) => {
let index = ctx.body.index;
ctx.assertPresent(index, "index is required");
ctx.assertIndexCharacters(
index,
"Index characters must be between x21 to x7E ASCII"
);
ctx.assertUuid(id, "id must be a uuid");
const user = ctx.state.user;