fix: Improve isChildDocument performance (#2284)

2021-07-07 17:23:40 +05:30
parent aeba8ce4eb
commit b037ae5dc1
1 changed files with 5 additions and 2 deletions
--- a/server/models/Collection.js
+++ b/server/models/Collection.js
@ -395,7 +395,11 @@ Collection.prototype.isChildDocument = function (
  let result = false;

  const loopChildren = (documents, input) => {
-    return documents.map((document) => {
+    if (result) {
+      return;
+    }
+
+    documents.forEach((document) => {
      let parents = [...input];
      if (document.id === documentId) {
        result = parents.includes(parentDocumentId);
@ -403,7 +407,6 @@ Collection.prototype.isChildDocument = function (
        parents.push(document.id);
        loopChildren(document.children, parents);
      }
-      return document;
    });
  };