coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Addressed flow issues

Browse Source
This commit is contained in:
Jori Lallo
2017-09-24 14:25:14 -07:00
parent 4ee532d65b
commit ba112f250a
3 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/components/DropdownMenu/DropdownMenu.js
View File

@ -28,14 +28,17 @@ type DropdownMenuProps = {
handleClick = (ev: SyntheticEvent) => { handleClick = (ev: SyntheticEvent) => {
ev.preventDefault(); ev.preventDefault();
ev.stopPropagation(); ev.stopPropagation();
const currentTarget = ev.currentTarget;
invariant(document.body, 'why you not here'); invariant(document.body, 'why you not here');
if (currentTarget instanceof HTMLDivElement) {
const bodyRect = document.body.getBoundingClientRect(); const bodyRect = document.body.getBoundingClientRect();
// $FlowIssue it's there const targetRect = currentTarget.getBoundingClientRect();
const targetRect = ev.currentTarget.getBoundingClientRect();
this.open = true; this.open = true;
this.top = targetRect.bottom - bodyRect.top; this.top = targetRect.bottom - bodyRect.top;
this.right = bodyRect.width - targetRect.left - targetRect.width; this.right = bodyRect.width - targetRect.left - targetRect.width;
if (this.props.onShow) this.props.onShow(); if (this.props.onShow) this.props.onShow();
}
}; };
handleClose = (ev: SyntheticEvent) => { handleClose = (ev: SyntheticEvent) => {

6
frontend/components/Layout/components/SidebarLink.js
View File

@ -9,7 +9,9 @@ const activeStyle = {
fontWeight: fontWeight.semiBold, fontWeight: fontWeight.semiBold,
}; };
// $FlowFixMe :/ // This is a hack for `styleComponent()` as NavLink fails to render without `to` prop
const StyleableDiv = props => <div {...props} />;
const styleComponent = component => styled(component)` const styleComponent = component => styled(component)`
display: block; display: block;
overflow: hidden; overflow: hidden;
@ -25,7 +27,7 @@ const styleComponent = component => styled(component)`
`; `;
function SidebarLink(props: Object) { function SidebarLink(props: Object) {
const Component = styleComponent(props.to ? NavLink : 'div'); const Component = styleComponent(props.to ? NavLink : StyleableDiv);
return <Component exact activeStyle={activeStyle} {...props} />; return <Component exact activeStyle={activeStyle} {...props} />;
} }

5
frontend/menus/CollectionMenu.js
View File

@ -11,8 +11,8 @@ import { DropdownMenu, DropdownMenuItem } from 'components/DropdownMenu';
@observer class CollectionMenu extends Component { @observer class CollectionMenu extends Component {
props: { props: {
label?: React$Element<any>, label?: React$Element<any>,
onShow?: Function, onShow?: () => void,
onClose?: Function, onClose?: () => void,
history: Object, history: Object,
ui: UiStore, ui: UiStore,
collection: Collection, collection: Collection,
@ -49,7 +49,6 @@ import { DropdownMenu, DropdownMenuItem } from 'components/DropdownMenu';
const MoreIcon = styled(Icon)` const MoreIcon = styled(Icon)`
width: 22px; width: 22px;
height: 22px;
`; `;
export default inject('ui')(CollectionMenu); export default inject('ui')(CollectionMenu);