From ff89e2849673a03aa7add44cf44ee83f9a5aacc1 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sat, 2 Sep 2017 13:38:52 -0700 Subject: [PATCH 1/2] Fixes: Hitting 'e' shortcut should not add an e to the document --- frontend/components/Layout/Layout.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/frontend/components/Layout/Layout.js b/frontend/components/Layout/Layout.js index b22c3eae..9679eb83 100644 --- a/frontend/components/Layout/Layout.js +++ b/frontend/components/Layout/Layout.js @@ -69,9 +69,13 @@ type Props = { } @keydown('e') - goToEdit() { - if (!this.props.documents.active) return; - this.props.history.push(documentEditUrl(this.props.documents.active)); + goToEdit(ev) { + const activeDocument = this.props.documents.active; + if (!activeDocument) return; + + ev.preventDefault(); + ev.stopPropagation(); + this.props.history.push(documentEditUrl(activeDocument)); } handleLogout = () => { From 9d133cce9810ab3b2e50377a3dbc73714b815af9 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sat, 2 Sep 2017 13:59:11 -0700 Subject: [PATCH 2/2] Disabled publish action should not be clickable --- .../Layout/components/HeaderAction/HeaderAction.scss | 1 - .../components/Layout/components/SaveAction/SaveAction.js | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/frontend/components/Layout/components/HeaderAction/HeaderAction.scss b/frontend/components/Layout/components/HeaderAction/HeaderAction.scss index 5e7bbec4..cc501390 100644 --- a/frontend/components/Layout/components/HeaderAction/HeaderAction.scss +++ b/frontend/components/Layout/components/HeaderAction/HeaderAction.scss @@ -2,7 +2,6 @@ display: flex; justify-content: center; align-items: center; - cursor: pointer; min-height: 43px; padding: 0 0.5rem; diff --git a/frontend/components/Layout/components/SaveAction/SaveAction.js b/frontend/components/Layout/components/SaveAction/SaveAction.js index ff307acb..f33cfec4 100644 --- a/frontend/components/Layout/components/SaveAction/SaveAction.js +++ b/frontend/components/Layout/components/SaveAction/SaveAction.js @@ -26,10 +26,9 @@ class SaveAction extends React.Component { return ( {showCheckmark && } {isNew ? 'Publish' : 'Save'} @@ -41,6 +40,9 @@ class SaveAction extends React.Component { const Link = styled.a` display: flex; align-items: center; + opacity: ${props => (props.disabled ? 0.5 : 1)}; + pointer-events: ${props => (props.disabled ? 'none' : 'auto')}; + cursor: ${props => (props.disabled ? 'default' : 'pointer')}; `; const SavedIcon = styled(CheckIcon)`