From cd7cbab5ac4befb6fea0ec5b2da00fb8d6ce255f Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Mon, 22 Feb 2021 21:53:20 -0800 Subject: [PATCH] =?UTF-8?q?fixes=20#1879=20=E2=80=93=20race=20condition=20?= =?UTF-8?q?in=20websockets=20service?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- server/services/websockets.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/services/websockets.js b/server/services/websockets.js index 1e777198..d5d3334f 100644 --- a/server/services/websockets.js +++ b/server/services/websockets.js @@ -369,6 +369,10 @@ export default class Websockets { method: ["withMembership", event.userId], }).findByPk(collectionGroup.collectionId); + if (!collection) { + continue; + } + const hasMemberships = collection.memberships.length > 0 || collection.collectionGroupMemberships.length > 0;