fix: Server error if non-array passed to users.invite

This commit is contained in:
Tom Moor 2021-06-07 20:28:28 -07:00
parent 4a8d357084
commit d8ca9c6111
3 changed files with 19 additions and 1 deletions

View File

@ -258,7 +258,7 @@ router.post("users.activate", auth(), async (ctx) => {
router.post("users.invite", auth(), async (ctx) => {
const { invites } = ctx.body;
ctx.assertPresent(invites, "invites is required");
ctx.assertArray(invites, "invites must be an array");
const { user } = ctx.state;
const team = await Team.findByPk(user.teamId);

View File

@ -167,6 +167,17 @@ describe("#users.invite", () => {
expect(body.data.sent.length).toEqual(1);
});
it("should require invites to be an array", async () => {
const user = await buildUser();
const res = await server.post("/api/users.invite", {
body: {
token: user.getJwtToken(),
invites: { email: "test@example.com", name: "Test", guest: false },
},
});
expect(res.status).toEqual(400);
});
it("should require admin", async () => {
const user = await buildUser();
const res = await server.post("/api/users.invite", {

View File

@ -1,5 +1,6 @@
// @flow
import { type Context } from "koa";
import { isArrayLike } from "lodash";
import validator from "validator";
import { validateColorHex } from "../../shared/utils/color";
import { validateIndexCharacters } from "../../shared/utils/indexCharacters";
@ -13,6 +14,12 @@ export default function validation() {
}
};
ctx.assertArray = (value, message) => {
if (!isArrayLike(value)) {
throw new ValidationError(message);
}
};
ctx.assertIn = (value, options, message) => {
if (!options.includes(value)) {
throw new ValidationError(message);