coop-cloud-chaos-patchs/outline
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat: Return view model from views.create (#1153)

Browse Source 
* feat: Return view model from views.create
Towards #1152

* fix: presenter data
This commit is contained in:
Tom Moor
2020-01-11 13:46:13 -08:00
committed by GitHub
parent cd3035a692
commit e38f4996ae
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/api/views.js
View File

@ -31,7 +31,7 @@ router.post('views.create', auth(), async ctx => {
const document = await Document.findByPk(documentId, { userId: user.id });
authorize(user, 'read', document);
await View.increment({ documentId, userId: user.id });
const view = await View.increment({ documentId, userId: user.id });
await Event.create({
name: 'views.create',
@ -43,8 +43,9 @@ router.post('views.create', auth(), async ctx => {
ip: ctx.request.ip,
});
view.user = user;
ctx.body = {
success: true,
data: presentView(view),
};
});

4
server/api/views.test.js
View File

@ -79,7 +79,7 @@ describe('#views.create', async () => {
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.success).toBe(true);
expect(body.data.count).toBe(1);
});
it('should allow creating a view record for document in read-only collection', async () => {
@ -100,7 +100,7 @@ describe('#views.create', async () => {
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.success).toBe(true);
expect(body.data.count).toBe(1);
});
it('should require authentication', async () => {