From f80c3c6877c16d72c9c485d2da3bc5843247dd6f Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Wed, 13 Mar 2019 23:22:12 -0700 Subject: [PATCH] Fixed: Return error when Slack auth fails to help with debugging --- server/auth/slack.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/server/auth/slack.js b/server/auth/slack.js index b93b12e9..d3ffce1f 100644 --- a/server/auth/slack.js +++ b/server/auth/slack.js @@ -29,8 +29,12 @@ router.get('slack.callback', auth({ required: false }), async ctx => { ctx.assertPresent(code || error, 'code is required'); ctx.assertPresent(state, 'state is required'); - if (state !== ctx.cookies.get('state') || error) { - ctx.redirect(`/?notice=auth-error`); + if (state !== ctx.cookies.get('state')) { + ctx.redirect('/?notice=auth-error'); + return; + } + if (error) { + ctx.redirect(`/?notice=auth-error&error=${error}`); return; }