26 Commits

Author SHA1 Message Date
a639875729 update Rails to latest patch version (6.1.3 -> 6.1.6) + other minor upgrades (#660) 2022-06-30 21:44:03 +02:00
f0c6a9e8f1 Update to Rails 6.1 2021-01-08 18:08:56 +01:00
13d0e411d7 rename dom selector + remove more useless entries in .gitignore 2021-01-05 16:04:51 +01:00
05c2228c28 [specs] DRY initialization by using the .rspec file 2020-12-21 21:40:23 +01:00
331ec8429a Yay! all tests passing 2020-12-16 00:14:19 +01:00
0bacdebc15 Merge branch 'develop' into rails_6 2020-02-26 00:04:29 +01:00
17bd6afec1 fixing features specs in travis 2020-02-23 18:09:40 +01:00
c0071212b2 more gem updates; minor js refactor; first pass over tests and first fixes :) 2019-09-26 02:16:05 +02:00
af7e3a6f91 remove destination accountable from transfer sources options 2019-04-12 09:33:59 +02:00
6ec52460d4 don't allow transfers of 0 hours and 0 minutes 2019-02-17 14:29:10 +01:00
22e09ed293 Use RSpec scope and avoid global namespace access. More info: https://relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/global-namespace-dsl
Closes #362
2018-08-30 20:52:48 +02:00
47812a90f0 Replace give_time link from users#show page 2018-01-18 17:26:19 +01:00
fc902afacb Use transfers :new template only
Now there's no point on using one for user/member and another one for
organization.
2017-08-19 21:05:19 +02:00
96f36b1461 Refactor assigns' specs to check HTML instead
This makes the controller specs integration-like enough to ensure things
keep working when we later refactor the views and the controller ivars.
2017-08-18 10:29:15 +02:00
24e5d6ad98 Use @accountable instead of @user or @organization
Then each particular view knows what type the accountable has and uses
the appropriate methods like user_path or organization_path.
2017-08-16 22:00:49 +02:00
fa3adf429f Abstract transfers controller by passing account
By specifying the account id we can abstract away from User or
Organization objects and trust just the account. As a result, this
removes ifs and therefore complexity.
2017-08-16 21:34:49 +02:00
69982abe8a Autofix cops and change style of spec 2017-08-16 20:11:26 +02:00
808ed91479 DRY #new by abstracting ivars into their methods
This is slowly turning "turning difference into sameness" following
Sandi Metz style.
2017-08-16 19:52:34 +02:00
9a1d6b098a Move #give_time from orgs to transfers controller
This duplicates the OrganizationsController#give_time to
TransferController#new as it should be by Rails conventions. We aim to
stick to REST conventions of the Transfer resource instead of having
custom actions on users and organizations controllers.
2017-08-16 19:39:44 +02:00
72b7bad68f Move #give_time from users to transfer controller
This duplicates the UsersController#give_time to TransferController#new
as it should be by Rails conventions. We aim to stick to REST
conventions of the Transfer resource instead of having custom actions on
users and organizations controllers.
2017-08-16 18:53:26 +02:00
bb70f79814 member: remove orphaned users after destroy last membership 2014-12-16 20:27:49 +01:00
23e27c6c02 All tests are successful again 2014-11-16 16:39:13 +01:00
375d01718c Redirect to the destination user.
See https://redbooth.com/a/#!/projects/638099/tasks/13502507

Thanks @danielmacho72
2014-09-29 23:28:15 +02:00
45af911164 Factored out login(user) from tests. 2014-09-29 22:42:13 +02:00
60a85a6c8d New tests for transfers_controller. New spec for inquiries_controller. New fabricators. 2013-11-07 19:44:57 +01:00
db3e6394f3 New spec for TransfersController. 2013-11-06 21:19:44 +01:00