From 65ba1136966a4bf80b2a26ca025156474b3fa6c7 Mon Sep 17 00:00:00 2001 From: 3wc <3wc.git@doesthisthing.work> Date: Sun, 21 Mar 2021 15:39:50 +0200 Subject: [PATCH] Lower Docker req to 19, make sure we test locally Ref #15 ``` $ docker --version Docker version 19.03.11, build 42e35e6 ``` But abra works. So I think 19 might be sufficient? Also, wondering if we should add `DOCKER_CONTEXT=default` to that check, to make sure we're not querying a remote server. (Semi-related question - should we also check remote Docker versions?) --- abra | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/abra b/abra index 9ef7453..6066012 100755 --- a/abra +++ b/abra @@ -479,9 +479,9 @@ require_yq() { } require_docker_version (){ - major_version=$(docker version --format "{{.Server.Version}}" | cut -d'.' -f1) + major_version=$(DOCKER_CONTEXT=default docker version --format "{{.Server.Version}}" | cut -d'.' -f1) - if [[ "$major_version" -lt 20 ]]; then + if [[ "$major_version" -lt 19 ]]; then error "This tool requires Docker v20 or greater. Please upgrade your Docker installation" exit 1 fi