From 5cacd09a04e8a014a1f5c3fc47824854fde51818 Mon Sep 17 00:00:00 2001
From: cellarspoon <cellarspoon@riseup.net>
Date: Tue, 28 Dec 2021 01:35:40 +0100
Subject: [PATCH] refactor: remove old/non-urgen/resolved FIXMEs

---
 cli/app/list.go             |  1 -
 cli/app/rollback.go         |  1 -
 cli/app/run.go              |  6 +-----
 pkg/config/app.go           |  3 ---
 pkg/upstream/stack/stack.go | 12 ------------
 scripts/installer/installer |  1 -
 6 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/cli/app/list.go b/cli/app/list.go
index aff457fd..4917c4a5 100644
--- a/cli/app/list.go
+++ b/cli/app/list.go
@@ -183,7 +183,6 @@ can take some time.
 							stats.latestCount++
 						}
 					} else {
-						// FIXME: jeezus golang why do you not have a list reverse function
 						for i, j := 0, len(newUpdates)-1; i < j; i, j = i+1, j-1 {
 							newUpdates[i], newUpdates[j] = newUpdates[j], newUpdates[i]
 						}
diff --git a/cli/app/rollback.go b/cli/app/rollback.go
index c1df7fb5..f9a7bb41 100644
--- a/cli/app/rollback.go
+++ b/cli/app/rollback.go
@@ -112,7 +112,6 @@ recipes.
 			}
 		}
 
-		// FIXME: jeezus golang why do you not have a list reverse function
 		for i, j := 0, len(availableDowngrades)-1; i < j; i, j = i+1, j-1 {
 			availableDowngrades[i], availableDowngrades[j] = availableDowngrades[j], availableDowngrades[i]
 		}
diff --git a/cli/app/run.go b/cli/app/run.go
index 8fa7d24b..8c074ac6 100644
--- a/cli/app/run.go
+++ b/cli/app/run.go
@@ -82,11 +82,7 @@ var appRunCommand = &cli.Command{
 			execCreateOpts.Tty = false
 		}
 
-		// FIXME: an absolutely monumental hack to instantiate another command-line
-		// client withing our command-line client so that we pass something down
-		// the tubes that satisfies the necessary interface requirements. We should
-		// refactor our vendored container code to not require all this cruft.  For
-		// now, It Works.
+		// FIXME: avoid instantiating a new CLI
 		dcli, err := command.NewDockerCli()
 		if err != nil {
 			logrus.Fatal(err)
diff --git a/pkg/config/app.go b/pkg/config/app.go
index 059eba6c..b3a48662 100644
--- a/pkg/config/app.go
+++ b/pkg/config/app.go
@@ -327,9 +327,6 @@ func GetAppStatuses(appFiles AppFiles) (map[string]map[string]string, error) {
 			if version, ok := service.Spec.Labels[labelKey]; ok {
 				result["version"] = version
 			} else {
-				//FIXME: we only need to check containers with the version label not
-				//       every single container and then skip when we see no label perf gains
-				//       to be had here
 				continue
 			}
 
diff --git a/pkg/upstream/stack/stack.go b/pkg/upstream/stack/stack.go
index 3c97909f..90d27530 100644
--- a/pkg/upstream/stack/stack.go
+++ b/pkg/upstream/stack/stack.go
@@ -360,18 +360,6 @@ func deployServices(
 			encodedAuth string
 		)
 
-		// FIXME: disable for now as not sure how to avoid having a `dockerCli`
-		// instance here and would rather not copy/pasta that entire module in
-		// right now for something that we don't even support right now. Will skip
-		// this for now.
-		if sendAuth {
-			// Retrieve encoded auth token from the image reference
-			// encodedAuth, err = command.RetrieveAuthTokenFromImage(ctx, dockerCli, image)
-			// if err != nil {
-			// 	return err
-			// }
-		}
-
 		if service, exists := existingServiceMap[name]; exists {
 			logrus.Infof("Updating service %s (id: %s)\n", name, service.ID)
 
diff --git a/scripts/installer/installer b/scripts/installer/installer
index e5e2372d..a7faf871 100755
--- a/scripts/installer/installer
+++ b/scripts/installer/installer
@@ -45,7 +45,6 @@ function install_abra_release {
   fi
 
 
-  # FIXME: support different architectures
   PLATFORM=$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m)
   FILENAME="abra_"$ABRA_VERSION"_"$PLATFORM""
   sed_command_rel='s/.*"assets":\[\{[^]]*"name":"'$FILENAME'"[^}]*"browser_download_url":"([^"]*)".*\].*/\1/p'