feat(installer): download rc with --rc #123

2021-11-09T12:33:33Z

knoflook commented

2021-11-09 12:33:33 +00:00

@decentral1se can you push a tag called 0.3.1-rc1? When I do this the files don't get uploaded. When its built you can run installer --rc and it will download rc1 :)

❤️ 1

decentral1se reviewed 2021-11-09 16:00:24 +00:00

decentral1se left a comment

Could we maybe put the duplicated code from both install_abra_rc and install_abra_release into functions? This will get hard to maintain going forward if we have to make changes in 2 places instead of one?

Could we maybe put the duplicated code from both `install_abra_rc` and `install_abra_release` into functions? This will get hard to maintain going forward if we have to make changes in 2 places instead of one?

decentral1se commented

2021-11-09 16:40:01 +00:00

Ohhh also super rad if you could extend https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/upgrade.go also to support --rc installs?

Ohhh also super rad if you could extend https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/upgrade.go also to support `--rc` installs?

decentral1se commented

2021-11-09 16:58:06 +00:00

When I do this the files don't get uploaded

I see no tag build on https://build.coopcloud.tech/coop-cloud/abra so maybe that is why? Also remember that you need to do git push --tags to get it to push the tag sometimes. This build failed in https://build.coopcloud.tech/coop-cloud/abra/358 but with 17a5f1529a done now, things should work 🙏

> When I do this the files don't get uploaded I see no tag build on https://build.coopcloud.tech/coop-cloud/abra so maybe that is why? Also remember that you need to do `git push --tags` to get it to push the tag sometimes. This build failed in https://build.coopcloud.tech/coop-cloud/abra/358 but with https://git.coopcloud.tech/coop-cloud/abra/commit/17a5f1529aa32da3abc9da7a44864c21966eea5e done now, things should work 🙏

knoflook force-pushed main from 3a6627218f to 9220a8c09b

2021-11-11 16:11:42 +00:00

Compare

knoflook commented

2021-11-11 16:15:05 +00:00

Could we maybe put the duplicated code from both install_abra_rc and install_abra_release into functions?

yeah sorry i did that the lazy way, gonna fix that now

Ohhh also super rad if you could extend https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/upgrade.go also to support --rc installs?

sure!

>Could we maybe put the duplicated code from both install_abra_rc and install_abra_release into functions? yeah sorry i did that the lazy way, gonna fix that now >Ohhh also super rad if you could extend https://git.coopcloud.tech/coop-cloud/abra/src/branch/main/cli/upgrade.go also to support --rc installs? sure!

knoflook added 1 commit 2021-11-11 16:40:44 +00:00

refactor(installer): remove doubled code for RC

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

5add4ccc1b

knoflook commented

2021-11-11 16:42:29 +00:00

once again, sorry for the atrocity that was the previous attempt at getting this to work. Turns out that the installer needed additional 8 lines, not 70. let's never speak of that code again

😆 1

decentral1se approved these changes 2021-11-11 17:07:37 +00:00

decentral1se left a comment

😀

decentral1se merged commit 5add4ccc1b into main

2021-11-11 17:07:46 +00:00

decentral1se referenced this pull request from toolshed/organising

2021-11-11 17:09:41 +00:00

Support RC releases for recipes #241

Sign in to join this conversation.