Consolidate SSH handling #255
No reviewers
Labels
No Label
bug
build
ci/cd
contributing
design
documentation
duplicate
enhancement
help wanted
invalid
meta
question
security
wontfix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: coop-cloud/abra#255
Loading…
Reference in New Issue
No description provided.
Delete Branch "conslidate-ssh"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is a breaking change. Docs PR is coop-cloud/docs.coopcloud.tech#124
Change log:
abra
can no longer install docker, initialise swarm and the proxy network. It will check if docker exists and is in swarm mode or not and error out accordingly. We leave the provisioning to tools that are designed for that.abra server add <host>
is the only interface now. The<host>
should correspond to aHost <host>
entry in your~/.ssh/config
or in anInclude <file>
statement (hosts are retrieved viassh -G <host>
). This means "how doesabra
interact with SSH is 1) do you have an~/.ssh/config
entry for<host>
2) can youssh <host>
successfully? 3) there is no 3. It's an easier mental model and also the wayabra-bash
works, hence, less weird obscure errors. Public<host>
names are still required.abra
no longer tries to do the TOFU host key verification prompt. We follow the praxis of the Docker cli itself and just give up when host keys are not validated. We leave it to folks to ssh and verify themselves.Refactored internal docker client creation & validation to only happen at command initialisation and be threaded down into the internals. It's easier to reason about where things might be going wrong for SSH connections in the code now.
Basically all of the custom SSH handling code is gone now! SSH connection building is done in one place and validated in one place.
--local
onserver add
still works, error messages are arguably better now.Concerns?
cef9eddb1d
tobdfe6ad1f7
bdfe6ad1f7
to9b2510108b
9b2510108b
to59d23d4206
59d23d4206
to2f59b18572
2f59b18572
to99757a2ae6
99757a2ae6
tod9eb0d9cbf
WIP: consolidate SSH handlingto Consolidate SSH handlingd9eb0d9cbf
toa0d3a0abcf
a0d3a0abcf
to4bcdb4e3cf
4bcdb4e3cf
toa0ba70352b
a0ba70352b
to05d5f27001
05d5f27001
toc1007adb7e