fix: better context handling and less unexpected deleting #262

decentral1se · 2023-01-23T14:02:53Z

decentral1se commented

2023-01-23 14:02:53 +00:00

abra app rm is now marked as "will delete all the things, watch out!". I've remove the volume/secret filtering, as that is present in the relevant "app secret/volume" sub-commands and have noted that in the help. The idea for this command was really to delete the local env file, once you've done that, abra can't help clean up anything. So, hopefully it's clear that you run this command at the very end of anything to do with the app and not just for cleaning up secrets or volumes. See app remove -h for more.

coop-cloud/organising#325

We don't clean up the servers dir if we find files in there.

coop-cloud/organising#340

We now (finally) have robust handling for missing docker contexts. You can now run abra app server ls --problems/-p to see which servers you're having problems with. We now filter on the contexts whenever a remote connection will get made and ensure we have a context, if not, we error out with a hopefully helpful message.

https://git.coopcloud.tech/coop-cloud/organising/issues/335 `abra app rm` is now marked as "will delete all the things, watch out!". I've remove the volume/secret filtering, as that is present in the relevant "app secret/volume" sub-commands and have noted that in the help. The idea for this command was really to delete the local env file, once you've done that, `abra` can't help clean up anything. So, hopefully it's clear that you run this command at the very end of anything to do with the app and not just for cleaning up secrets or volumes. See `app remove -h` for more. ![image](/attachments/5725d8de-2486-4b8c-a1ab-9b8d5783864b) --- https://git.coopcloud.tech/coop-cloud/organising/issues/325 We don't clean up the servers dir if we find files in there. --- https://git.coopcloud.tech/coop-cloud/organising/issues/340 We now (finally) have robust handling for missing docker contexts. You can now run `abra app server ls --problems/-p` to see which servers you're having problems with. We now filter on the contexts whenever a remote connection will get made and ensure we have a context, if not, we error out with a hopefully helpful message. ![image](/attachments/34f744f1-fb87-49ef-a038-4a50c50232c4)

image.png

27 KiB

image.png

55 KiB

decentral1se added 3 commits 2023-01-23 14:03:29 +00:00

a93786c6be

fix!: make "app rm" more explicit & simpler

We point users to "app volume/secret remove" for more specific deletion
of other app data resources now. The idea is that if you lose the env
file locally, then you can't clean up anything after. So it is handy to
have a sort of WARNING barrier to deleting that file. This flow is the
only way to get Abra to delete your local env file. It now feels more
documented and sufficiently scary in the UI/UX to merit that. Hopefully
addresses the ticket sufficiently.

Closes coop-cloud/organising#335.

27e0708ac7

fix: don't delete server dir on cleanup if not empty

Part of coop-cloud/organising#325.

continuous-integration/drone/pr Build is failing Details

continuous-integration/drone/push Build is failing Details

b089109c94

fix: more robust docker context problem handling

See coop-cloud/organising#325
See coop-cloud/organising#340

decentral1se merged commit b089109c94 into main

2023-01-23 14:13:59 +00:00

decentral1se deleted branch dont-delete-shit-unexpectedly

2023-01-23 14:14:05 +00:00

decentral1se referenced this pull request from coop-cloud/organising

2023-01-23 14:14:34 +00:00

Missing FOO server connection details when symlinking ~/.abra/servers/FOO #340

decentral1se referenced this pull request from coop-cloud/organising

2023-01-23 14:14:42 +00:00

Avoid deleting data without prompt #325

Sign in to join this conversation.

No reviewers

No Label