coop-cloud/abra
coop-cloud
/
abra
5
2
Fork 15
Code Issues Pull Requests 4 Packages Releases 36 Activity

fix: add warning for long secret names #359

Merged
decentral1se merged 14 commits from rix/abra:add-secret-length-linting into main 2024-04-06 21:41:37 +00:00
Conversation 8 Commits 14 Files Changed 6 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2abb7264b8 - Show all commits

2
cli/app/new.go
View File

@ -270,7 +270,7 @@ func ensureSecretLengths(secrets map[string]string, domainName string, sanitised
for secretName := range secrets {
if len(secretName)+domainAndFormatLength > config.MAX_DOCKER_SECRET_LENGTH {
return fmt.Errorf("%s is too long (> %d chars when combined with %s)", secretName, config.MAX_DOCKER_SECRET_LENGTH, sanitisedAppName)
return fmt.Errorf("secret %s is too long (> %d chars when combined with %s)", secretName, config.MAX_DOCKER_SECRET_LENGTH, sanitisedAppName)
}
}
decentral1se marked this conversation as resolved Outdated
decentral1se commented 2023-10-03 23:11:58 +00:00
Outdated
Review
Copy Link

nitpick: drop extra newline?

nitpick: drop extra newline?
rix commented 2023-10-04 18:10:55 +00:00
Outdated
Review
Copy Link

Think I've got this one now but let me know if I misinterpreted which line you were talking about : )

Think I've got this one now but let me know if I misinterpreted which line you were talking about : )
❤️ 1