<!-- Note: When adding a new entry, a default must be set in WSD in case the entry is missing upon deployment. -->
<allowed_languages desc="List of supported languages of Writing Aids (spell checker, grammar checker, thesaurus, hyphenation) on this instance. Allowing too many has negative effect on startup performance." default="de_DE en_GB en_US es_ES fr_FR it nl pt_BR pt_PT ru">de_DE en_GB en_US es_ES fr_FR it nl pt_BR pt_PT ru</allowed_languages>
<allowed_languages desc="List of supported languages of Writing Aids (spell checker, grammar checker, thesaurus, hyphenation) on this instance. Allowing too many has negative effect on startup performance." default="{{ env "DICTIONARIES" }}">{{ env "DICTIONARIES" }}</allowed_languages>
@jeppebundsgaard thanks for adding this. What is missing is a bump of the config version in abra.sh. I think you can leave it for now, as I will do it together with the upgrade to collabora 26.
@jeppebundsgaard thanks for adding this. What is missing is a bump of the config version in abra.sh. I think you can leave it for now, as I will do it together with the upgrade to collabora 26.
@jeppebundsgaard FYI: another thing I just saw after merging is, that your change is not backwards compatible on another issue: deployments with older versions currently get the dictionaries hardcoded from the xml, but now the env variable is empty if they do not add it to their env file manually while upgrading. (What happens in reality quiet a lot) Therefore I will add the currently added languages as default value for DIRECTORIES env var in the compose file. So the behaviour will stay the same even if operators do not do anything besides the upgrade command
@jeppebundsgaard FYI: another thing I just saw after merging is, that your change is not backwards compatible on another issue: deployments with older versions currently get the dictionaries hardcoded from the xml, but now the env variable is empty if they do not add it to their env file manually while upgrading. (What happens in reality quiet a lot) Therefore I will add the currently added languages as default value for DIRECTORIES env var in the compose file. So the behaviour will stay the same even if operators do not do anything besides the upgrade command
Sorry, I am an amateur! :-) I have reopened, and hope you will perform the right action ...
> > > @jeppebundsgaard this closes #6 right?
> >
> > Yes, thanks!
>
> did you want to close the PR??
Sorry, I am an amateur! :-) I have reopened, and hope you will perform the right action ...
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
@@ -8,3 +8,3 @@<!-- Note: When adding a new entry, a default must be set in WSD in case the entry is missing upon deployment. --><allowed_languages desc="List of supported languages of Writing Aids (spell checker, grammar checker, thesaurus, hyphenation) on this instance. Allowing too many has negative effect on startup performance." default="de_DE en_GB en_US es_ES fr_FR it nl pt_BR pt_PT ru">de_DE en_GB en_US es_ES fr_FR it nl pt_BR pt_PT ru</allowed_languages><allowed_languages desc="List of supported languages of Writing Aids (spell checker, grammar checker, thesaurus, hyphenation) on this instance. Allowing too many has negative effect on startup performance." default="{{ env "DICTIONARIES" }}">{{ env "DICTIONARIES" }}</allowed_languages>@jeppebundsgaard thanks for adding this. What is missing is a bump of the config version in abra.sh. I think you can leave it for now, as I will do it together with the upgrade to collabora 26.
@jeppebundsgaard FYI: another thing I just saw after merging is, that your change is not backwards compatible on another issue: deployments with older versions currently get the dictionaries hardcoded from the xml, but now the env variable is empty if they do not add it to their env file manually while upgrading. (What happens in reality quiet a lot) Therefore I will add the currently added languages as default value for DIRECTORIES env var in the compose file. So the behaviour will stay the same even if operators do not do anything besides the upgrade command
Good point, thanks!
@jeppebundsgaard this closes #6 right?
Yes, thanks!
did you want to close the PR??
Sorry, I am an amateur! :-) I have reopened, and hope you will perform the right action ...