coop-cloud/custom-php
coop-cloud
/
custom-php
1
1
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Versioning: A Proposal #1

New Issue
Open
opened 2023-03-28 15:46:25 +00:00 by 3wordchant · 0 comments
3wordchant commented 2023-03-28 15:46:25 +00:00
Owner
Copy Link

Currently, compose.yml uses a variable for the PHP image in all cases.

This makes it hard to crowbar into our recipe versioning scheme.

Based on recent explorations with the RStudio image, my suggestion is:

  • Use a specific PHP version in compose.yml (I don't care which), use that version number in the recipe version (e.g. 0.1.0+7.3)
  • Add an optional compose.version.yml, changing services.app.image to use PHP_VERSION (as current), update .env.sample to show how to enable that extra compose file and set the version.

@mayel, as probably this recipe's only-est user, how does that sound?

Currently, `compose.yml` uses a variable for the PHP image in all cases. This makes it hard to crowbar into our [recipe versioning scheme](https://docs.coopcloud.tech/maintainers/handbook/#how-are-recipes-versioned). Based on recent explorations with the RStudio image, my suggestion is: - Use a specific PHP version in `compose.yml` (I don't care which), use that version number in the recipe version (e.g. 0.1.0+7.3) - Add an optional `compose.version.yml`, changing `services.app.image` to use `PHP_VERSION` (as current), update `.env.sample` to show how to enable that extra compose file and set the version. @mayel, as probably this recipe's only-est user, how does that sound?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/custom-php#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?