Deploying a new Gitea instance fails because of secret naming #10

New Issue

Closed

opened 2021-04-04 15:49:41 +00:00 by 3wordchant · 2 comments

3wordchant commented 2021-04-04 15:49:41 +00:00

Owner

Copy Link

1. abra app gitea_example_com secret generate --all fails because it tries to generate a secret called #secret_smtp_password -- i.e. it seems abra isn't skipping commented-out lines properly.
2. abra app gitea_example_com secret deploy fails:
   1. secret_smtp_password is required, because it's referenced in the main compose.yml file -- it would be nice if this were optional, as not everyone will need to provide an SMTP password. If it isn't optional, we should uncomment it in .env.sample
   2. The secret variable names in .env.sample have PASSWORD, where the compose.yml file is looking for passwd

1. `abra app gitea_example_com secret generate --all` fails because it tries to generate a secret called `#secret_smtp_password` -- i.e. it seems `abra` isn't skipping commented-out lines properly. 2. `abra app gitea_example_com secret deploy` fails: 1. `secret_smtp_password` is required, because it's referenced in the main `compose.yml` file -- it would be nice if this were optional, as not everyone will need to provide an SMTP password. If it isn't optional, we should uncomment it in `.env.sample` 2. The secret variable names in `.env.sample` have `PASSWORD`, where the `compose.yml` file is looking for `passwd`

decentral1se commented 2021-04-04 18:02:27 +00:00

Owner

Copy Link

Aha! Made https://git.autonomic.zone/coop-cloud/abra/issues/133. Also see cb8e0a819b/compose.yml (L92-L93) (was putting this off because of the busywork of migrating our own instance). Making the SMTP password optional is definitely a good idea. There is some config to wrap in a conditional also. Probably other things could be made optional.

Aha! Made https://git.autonomic.zone/coop-cloud/abra/issues/133. Also see https://git.autonomic.zone/coop-cloud/gitea/src/commit/cb8e0a819beac4c32c7b8c89f6dc5bfffe84f958/compose.yml#L92-L93 (was putting this off because of the busywork of migrating our own instance). Making the SMTP password optional is definitely a good idea. There is some config to wrap in a conditional also. Probably other things could be made optional.

❤️ 1

decentral1se referenced this issue from a commit 2021-04-07 11:42:17 +00:00

Make SMTP mailer experimental

decentral1se referenced this issue from a commit 2021-04-07 11:47:49 +00:00

Final hold out on passwd -> password migration

decentral1se commented 2021-04-07 11:51:14 +00:00

Owner

Copy Link

This is resolved now :) https://git.autonomic.zone/coop-cloud/abra/issues/133 is still outstanding but now that the SMTP configurations are totally optional, things are only generated when needed.

This is resolved now :) https://git.autonomic.zone/coop-cloud/abra/issues/133 is still outstanding but now that the SMTP configurations are totally optional, things are only generated when needed.

decentral1se closed this issue 2021-04-07 11:51:14 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

upgrade

lfs

smtp

push-to-create

work-path

backup-label

indexer

cr_landing_page

add_forgejo

postgres-db

cors-headers

renovate/master-docker-gitea-gitea-1.x

3.5.2+1.24.2-rootless

3.5.1+1.24.2-rootless

3.5.0+1.24.2-rootless

3.4.0+1.24.2-rootless

3.3.1+1.23.8-rootless

3.3.0+1.23.1-rootless

3.2.0+1.23.1-rootless

3.1.1+1.23.1-rootless

3.1.0+1.23.0-rootless

3.0.3+1.22.6-rootless

3.0.2+1.22.6-rootless

3.0.1+1.22.3-rootless

3.0.0+1.22.2-rootless

2.11.0+1.22.2-rootless

2.10.1+1.22.2-rootless

2.10.0+1.22.1-rootless

2.9.1+1.22.0-rootless

2.9.0+1.22.0-rootless

2.8.0+1.21.11-rootless

2.7.0+1.21.11-rootless

2.6.2+1.21.10-rootless

2.6.1+1.21.10-rootless

2.6.0+1.21.5-rootless

2.5.2+1.21.5-rootless

2.5.1+1.21.4-rootless

2.5.0+1.21.1-rootless

2.4.0+1.21.0-rootless

2.3.3+1.20.5-rootless

2.3.1+1.20.1-rootless

2.3.2+1.20.3-rootless

2.1.2+1.19.3-rootless

1.3.1+1.17.3-rootless

2.3.0+1.20.1-rootless

2.2.0+1.19.3-rootless

2.1.0+1.18.5-rootless

2.0.1+1.18.2-rootless

2.0.0+1.18.0-rootless

1.3.0+1.17.2-rootless

1.2.1+1.16.8-rootless

1.2.0+1.16.3-rootless

1.1.3+1.15.10-rootless

1.1.2+1.15.6-rootless

1.1.1+1.15.3-rootless

1.1.0+1.15.0-rootless

1.0.0+1.14.5-rootless

Labels

No items

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/gitea#10

No description provided.