I'm a bit nervous about Postgres, because major version upgrades have been incredibly cursed when I've done them before.
They usually involve pg_dumpall / pg_restore either side of the upgrade because (from what I understand, anyway) the server app doesn't know how to upgrade data storage formats, won't launch if it detects an old data format, a pg_upgrade command exists but has some exciting requirements which are very hard to meet:
pg_upgrade functionality is perfectly clear: you need to have both postgres [old] and [new] versions installed at the same time to upgrade the data structures on disk. But what is not clear is the best way of going about the upgrade when using containers, since every container only has a single version of postgres available/installed.
— "Upgrading between major versions?"
I'm self-interestedly fine with an optimistic merge of this full PR anyway, because I'm not running any Postgres-based Gitea instances, but it would be awesome if we could include a recipe release note warning about this fiasco, and even more awesome if we could find a way to automate the upgrade somehow.
Amazing praxis @javielico 🤘
Gitea and MySQL should be smooth, 👍 on these.
I'm a bit nervous about Postgres, because major version upgrades have been *incredibly* cursed when I've done them before.
They usually involve `pg_dumpall` / `pg_restore` either side of the upgrade because (from what I understand, anyway) the server app doesn't know how to upgrade data storage formats, won't launch if it detects an old data format, a `pg_upgrade` command exists but has some exciting requirements which are very hard to meet:
> pg_upgrade functionality is perfectly clear: you need to have both postgres [old] and [new] versions installed at the same time to upgrade the data structures on disk. But what is not clear is the best way of going about the upgrade when using containers, since every container only has a single version of postgres available/installed.
> — ["Upgrading between major versions?"](https://github.com/docker-library/postgres/issues/37)
I'm self-interestedly fine with an [optimistic merge](http://hintjens.com/blog:106) of this full PR anyway, because I'm not running any Postgres-based Gitea instances, but it would be awesome if we could include [a recipe release note](https://docs.coopcloud.tech/maintainers/handbook/#how-do-i-write-version-release-notes) warning about this fiasco, and even more awesome if we could find a way to automate the upgrade somehow.
Let me review on the recipe release note and see what we can do about the migration. We could perhaps bump Pgsql to a version that still updated but it's not a major upgrade? The one we had in the recipe before had reached EOL.
Let me review on the recipe release note and see what we can do about the migration. We could perhaps bump Pgsql to a version that still updated but it's not a major upgrade? The one we had in the recipe before had reached EOL.
Thank you for reviewing the PR @3wordchant 🚀
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Amazing praxis @javielico 🤘
Gitea and MySQL should be smooth, 👍 on these.
I'm a bit nervous about Postgres, because major version upgrades have been incredibly cursed when I've done them before.
They usually involve
pg_dumpall/pg_restoreeither side of the upgrade because (from what I understand, anyway) the server app doesn't know how to upgrade data storage formats, won't launch if it detects an old data format, apg_upgradecommand exists but has some exciting requirements which are very hard to meet:I'm self-interestedly fine with an optimistic merge of this full PR anyway, because I'm not running any Postgres-based Gitea instances, but it would be awesome if we could include a recipe release note warning about this fiasco, and even more awesome if we could find a way to automate the upgrade somehow.
Let me review on the recipe release note and see what we can do about the migration. We could perhaps bump Pgsql to a version that still updated but it's not a major upgrade? The one we had in the recipe before had reached EOL.
Thank you for reviewing the PR @3wordchant 🚀
Added a warning message as discussed @3wordchant
Beautiful, thanks @javielico! I'm happy for us to merge this whenever you feel ready 👌
🚀