coop-cloud/gitea
coop-cloud/gitea
5
2
Fork 4
Code Issues 4 Pull Requests 1 Releases Wiki Activity

Updated images for MariaDB/Gitea and Postgres to latest stable or LTS #31

Merged
javielico merged 5 commits from :master into master 2023-05-18 10:36:26 +00:00
Conversation 5 Commits 5 Files Changed 4 +6 -4
javielico commented 2023-05-08 20:04:22 +00:00
Member
Copy Link
No description provided.
javielico added 4 commits 2023-05-08 20:04:24 +00:00 
Reviewed-on: javielico/gitea#1
Mariadb to stable lts 10.11.2
Some checks failed
continuous-integration/drone/pr Build is failing
Details
b73b167b98
3wordchant commented 2023-05-08 20:37:09 +00:00
Owner
Copy Link

Amazing praxis @javielico 🤘

Gitea and MySQL should be smooth, 👍 on these.

I'm a bit nervous about Postgres, because major version upgrades have been incredibly cursed when I've done them before.

They usually involve pg_dumpall / pg_restore either side of the upgrade because (from what I understand, anyway) the server app doesn't know how to upgrade data storage formats, won't launch if it detects an old data format, a pg_upgrade command exists but has some exciting requirements which are very hard to meet:

pg_upgrade functionality is perfectly clear: you need to have both postgres [old] and [new] versions installed at the same time to upgrade the data structures on disk. But what is not clear is the best way of going about the upgrade when using containers, since every container only has a single version of postgres available/installed.
— "Upgrading between major versions?"

I'm self-interestedly fine with an optimistic merge of this full PR anyway, because I'm not running any Postgres-based Gitea instances, but it would be awesome if we could include a recipe release note warning about this fiasco, and even more awesome if we could find a way to automate the upgrade somehow.

Amazing praxis @javielico 🤘 Gitea and MySQL should be smooth, 👍 on these. I'm a bit nervous about Postgres, because major version upgrades have been *incredibly* cursed when I've done them before. They usually involve `pg_dumpall` / `pg_restore` either side of the upgrade because (from what I understand, anyway) the server app doesn't know how to upgrade data storage formats, won't launch if it detects an old data format, a `pg_upgrade` command exists but has some exciting requirements which are very hard to meet: > pg_upgrade functionality is perfectly clear: you need to have both postgres [old] and [new] versions installed at the same time to upgrade the data structures on disk. But what is not clear is the best way of going about the upgrade when using containers, since every container only has a single version of postgres available/installed. > — ["Upgrading between major versions?"](https://github.com/docker-library/postgres/issues/37) I'm self-interestedly fine with an [optimistic merge](http://hintjens.com/blog:106) of this full PR anyway, because I'm not running any Postgres-based Gitea instances, but it would be awesome if we could include [a recipe release note](https://docs.coopcloud.tech/maintainers/handbook/#how-do-i-write-version-release-notes) warning about this fiasco, and even more awesome if we could find a way to automate the upgrade somehow.
javielico commented 2023-05-08 22:44:06 +00:00
Author
Member
Copy Link

Let me review on the recipe release note and see what we can do about the migration. We could perhaps bump Pgsql to a version that still updated but it's not a major upgrade? The one we had in the recipe before had reached EOL.

Thank you for reviewing the PR @3wordchant 🚀

Let me review on the recipe release note and see what we can do about the migration. We could perhaps bump Pgsql to a version that still updated but it's not a major upgrade? The one we had in the recipe before had reached EOL. Thank you for reviewing the PR @3wordchant 🚀
javielico added 1 commit 2023-05-09 19:31:25 +00:00
Added commit message warning about Pgsql upgrade
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e3749d3038
javielico commented 2023-05-09 19:31:49 +00:00
Author
Member
Copy Link

Added a warning message as discussed @3wordchant

Added a warning message as discussed @3wordchant
3wordchant commented 2023-05-09 21:23:23 +00:00
Owner
Copy Link

Beautiful, thanks @javielico! I'm happy for us to merge this whenever you feel ready 👌

Beautiful, thanks @javielico! I'm happy for us to merge this whenever you feel ready 👌
javielico changed title from WIP: Updated images for MariaDB/Gitea and Postgres to latest stable or LTS to Updated images for MariaDB/Gitea and Postgres to latest stable or LTS 2023-05-18 10:36:15 +00:00
javielico merged commit bdf092e75b into master 2023-05-18 10:36:26 +00:00
javielico commented 2023-05-18 10:36:53 +00:00
Author
Member
Copy Link

🚀

🚀
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/gitea#31
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?