refactor: simplfiy for...range loops

cli/app/check.go

@@ -46,7 +46,7 @@ var appCheckCommand = &cli.Command{
 		}
 
 		var missing []string
-		for k, _ := range envSample {
+		for k := range envSample {
 			if _, ok := appEnv.Env[k]; !ok {
 				missing = append(missing, k)
 			}

cli/app/cp.go

@@ -111,14 +111,15 @@ var appCpCommand = &cli.Command{
 			}
 		} else {
 			content, _, err := cl.CopyFromContainer(ctx, container.ID, srcPath)
+			defer content.Close()
 			if err != nil {
 				logrus.Fatal(err)
 			}
 			fromTarOpts := &archive.TarOptions{NoOverwriteDirNonDir: true, Compression: archive.Gzip}
-			archive.Untar(content, dstPath, fromTarOpts)
-			defer content.Close()
+			if err := archive.Untar(content, dstPath, fromTarOpts); err != nil {
+				logrus.Fatal(err)
+			}
 		}
-
 		return nil
 	},
 }

cli/app/secret.go

@@ -58,7 +58,7 @@ var appSecretGenerateCommand = &cli.Command{
 		} else {
 			secretName := c.Args().Get(1)
 			secretVersion := c.Args().Get(2)
-			for sec, _ := range secretEnvVars {
+			for sec := range secretEnvVars {
 				parsed := secret.ParseSecretEnvVarName(sec)
 				if secretName == parsed {
 					secretsToCreate[sec] = secretVersion