toolshed/abra
toolshed/abra
4
2
Fork 18
Code Issues 29 Pull Requests 3 Packages Releases 40 Activity

fix: throw an error when trying to edit config for nonexistent app #69

Closed
knoflook wants to merge 1 commits from knoflook:config-fix into main
pull from: knoflook:config-fix
merge into: toolshed:main
Conversation 2 Commits 1 Files Changed 1 +3
knoflook commented 2021-09-04 06:12:49 +00:00
Owner
Copy Link

closes #67

closes #67
knoflook added 1 commit 2021-09-04 06:12:50 +00:00
fix: throw an error when trying to edit config for nonexistent app
All checks were successful
continuous-integration/drone/pr Build is passing
Details
345586f737
decentral1se requested changes 2021-09-04 18:20:27 +00:00
cli/app/config.go
@ -38,2 +38,4 @@
}
if appFiles[appName].Path == "" {
return errors.New("app doesn't exist")
decentral1se commented 2021-09-04 18:20:20 +00:00
Owner
Copy Link
logrus.Fatalf("'%s' doesn't exist?", appFiles[appName].Path)
```golang logrus.Fatalf("'%s' doesn't exist?", appFiles[appName].Path) ```
decentral1se commented 2021-09-05 19:48:59 +00:00
Owner
Copy Link

Doing some refactoring and got a fix in 273db078b0 for this. Aiming to spare you the merge conflict 🤕 Will close this off. Thanks!

Doing some refactoring and got a fix in https://git.coopcloud.tech/coop-cloud/go-abra/commit/273db078b03f4fa4b8e3d71fb23719bba334aaa4 for this. Aiming to spare you the merge conflict 🤕 Will close this off. Thanks!
decentral1se closed this pull request 2021-09-05 19:49:16 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
build
go build related issues
ci/cd
Building things with CI/CD
contributing
Dealing with contributing
critical fix
https://docs.coopcloud.tech/federation/resolutions/passed/010/
design
UI/UX
documentation
Documenting all the things
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
meta
relating to the project or repo itself
question
More information is needed
release
Release management
release-candidate
Related to the new release candidate
security
Security related
test
Unit/integration testing
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3wordchant abra-bot ammaratef45 Apfelwurm carla cas decentral1se fauno kawaiipunk knoflook lambdabundesverband moritz p4u1 simon trav val yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: toolshed/abra#69
No description provided.
Delete Branch "knoflook:config-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?