fix: throw an error when trying to edit config for nonexistent app #69

knoflook · 2021-09-04T06:12:49Z

knoflook commented

2021-09-04 06:12:49 +00:00

closes #67

knoflook added 1 commit 2021-09-04 06:12:50 +00:00

continuous-integration/drone/pr Build is passing Details

345586f737

fix: throw an error when trying to edit config for nonexistent app

decentral1se requested changes 2021-09-04 18:20:27 +00:00

cli/app/config.go

						
				@ -38,2 +38,4 @@

						}

						if appFiles[appName].Path == "" {

							return errors.New("app doesn't exist")

decentral1se commented

2021-09-04 18:20:20 +00:00

logrus.Fatalf("'%s' doesn't exist?", appFiles[appName].Path)

```golang logrus.Fatalf("'%s' doesn't exist?", appFiles[appName].Path) ```

decentral1se referenced this issue from a commit

2021-09-05 19:47:30 +00:00

fix: bail out if app doesn't exist

decentral1se commented

2021-09-05 19:48:59 +00:00

Doing some refactoring and got a fix in 273db078b0 for this. Aiming to spare you the merge conflict 🤕 Will close this off. Thanks!

Doing some refactoring and got a fix in https://git.coopcloud.tech/coop-cloud/go-abra/commit/273db078b03f4fa4b8e3d71fb23719bba334aaa4 for this. Aiming to spare you the merge conflict 🤕 Will close this off. Thanks!

decentral1se closed this pull request

2021-09-05 19:49:16 +00:00

continuous-integration/drone/pr Build is passing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label