Question: Optional defaults for environment variables in entrypoint.sh.tmpl #2

New Issue

Open

opened 2024-03-27 06:05:15 +00:00 by cgalo5758 · 2 comments

cgalo5758 commented 2024-03-27 06:05:15 +00:00

Copy Link

Copy Source

I was wondering why the file_env function in entrypoint.sh.tmpl takes a second argument $2, which seems to be an optional default value for the environment variable being set.

However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument:

file_env TYPEORM_PASSWORD
file_env GRIST_SESSION_SECRET

Additionally, I am not sure it makes sense to manage defaults outside of the compose.yml file and inside this template.

Maybe I am missing something here?🤔

I was wondering why the `file_env` function in `entrypoint.sh.tmpl` takes a second argument `$2`, which seems to be an optional default value for the environment variable being set. However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument: ``` file_env TYPEORM_PASSWORD file_env GRIST_SESSION_SECRET ``` Additionally, I am not sure it makes sense to manage defaults outside of the `compose.yml` file and inside this template. Maybe I am missing something here?🤔

cgalo5758 started working 2024-03-27 06:05:23 +00:00

cgalo5758 commented 2024-03-27 06:12:24 +00:00

Author

Copy Link

Copy Source

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file.

Maybe this is just something related to abra that I am not aware of?

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file. Maybe this is just something related to `abra` that I am not aware of?

cgalo5758 commented 2024-06-21 21:02:57 +00:00

Author

Copy Link

Copy Source

Was also curious about this line:

exec ./sandbox/run.sh $@

What is run.sh? Does that directory even exist?

Was also curious about this line: ``` exec ./sandbox/run.sh $@ ``` What is run.sh? Does that directory even exist?

cgalo5758 canceled time tracking 2025-01-23 09:12:49 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

renovate/gristlabs-grist-oss-1.x

renovate/redis-8.x

3.6.2+1.7.17

3.6.1+1.7.16

3.6.0+1.7.15

3.5.0+1.7.15

3.4.0+1.7.13

3.3.1+1.7.12

3.3.0+1.7.11

3.2.0+1.7.10

3.1.0+1.7.8

3.0.0+1.7.7

2.11.0+1.7.7

2.10.4+1.7.4

2.10.3+1.7.3

2.10.2+1.7.2

2.10.1+1.7.2

2.10.0+1.7.1

2.9.0+1.6.0

2.8.1+1.5.1

2.7.0+1.4.2

2.6.0+1.3.2

2.5.0+1.2.0

2.4.0+1.1.18

2.3.1+1.1.17

2.3.0+1.1.17

2.2.0+1.1.16

2.1.1+1.1.15

2.1.0+1.1.15

2.0.0+1.1.14

1.0.2+1.1.14

1.0.1+1.1.12

1.0.0+1.1.12

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

3wordchant aadil (Aadil Ayub) abra-bot (Abra Bot) ammaratef45 amras (Sarma) Apfelwurm appletalk arjan basebuilder BornDeleuze Brooke carla cas (Cassowary) codegod100 coopcloud cyrnel decentral1se (d1) dede devydave fauno (fauno) flancian Frando iexos jade (Jade Ambrose) javielico (Javielico) jjsfunhouse jmakdah2 (Jackie Makdah) joe-irving (Joe Irving) kawaiipunk (KawaiiPunk) knoflook kolaente lambdabundesverband linnealovespie (April) marlon (marlon) mayel mirsal moosemower moritz nicksellen (Nick Sellen) notplants oxaliq (sorrel) p4u1 pau pharaohgraphy (Andrew 🐦‍🔥❤️‍🔥✴️) PhiNatalie renovate-bot (Comrade Renovate Bot) ripclap rix rscmbbng sef (sef) simon sixsmith (Sixsmith) stevensting tobias trav (Trav Fryer) val (val (he/him)) vaznasty virtualboys wolcen (Chris Thompson) wykwit xynosis yksflip

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/grist#2