coop-cloud/grist
coop-cloud
/
grist
0
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases Wiki Activity

Question: Optional defaults for environment variables in entrypoint.sh.tmpl #2

New Issue
Open
opened 2024-03-27 06:05:15 +00:00 by cgalo5758 · 1 comment
cgalo5758 commented 2024-03-27 06:05:15 +00:00
Copy Link

I was wondering why the file_env function in entrypoint.sh.tmpl takes a second argument $2, which seems to be an optional default value for the environment variable being set.

However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument:

file_env TYPEORM_PASSWORD
file_env GRIST_SESSION_SECRET

Additionally, I am not sure it makes sense to manage defaults outside of the compose.yml file and inside this template.

Maybe I am missing something here?🤔

I was wondering why the `file_env` function in `entrypoint.sh.tmpl` takes a second argument `$2`, which seems to be an optional default value for the environment variable being set. However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument: ``` file_env TYPEORM_PASSWORD file_env GRIST_SESSION_SECRET ``` Additionally, I am not sure it makes sense to manage defaults outside of the `compose.yml` file and inside this template. Maybe I am missing something here?🤔
cgalo5758 started working 2024-03-27 06:05:23 +00:00
cgalo5758 commented 2024-03-27 06:12:24 +00:00
Author
Copy Link

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file.

Maybe this is just something related to abra that I am not aware of?

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file. Maybe this is just something related to `abra` that I am not aware of?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
1.0.0+1.1.12
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/grist#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?