Question: Optional defaults for environment variables in entrypoint.sh.tmpl #2

New Issue

Open

opened 2024-03-27 06:05:15 +00:00 by cgalo5758 · 2 comments

cgalo5758 commented 2024-03-27 06:05:15 +00:00

Copy Link

I was wondering why the file_env function in entrypoint.sh.tmpl takes a second argument $2, which seems to be an optional default value for the environment variable being set.

However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument:

file_env TYPEORM_PASSWORD
file_env GRIST_SESSION_SECRET

Additionally, I am not sure it makes sense to manage defaults outside of the compose.yml file and inside this template.

Maybe I am missing something here?🤔

I was wondering why the `file_env` function in `entrypoint.sh.tmpl` takes a second argument `$2`, which seems to be an optional default value for the environment variable being set. However, from what I can see, this default value feature is not being utilized in the script. The file_env function is called twice without providing a second argument: ``` file_env TYPEORM_PASSWORD file_env GRIST_SESSION_SECRET ``` Additionally, I am not sure it makes sense to manage defaults outside of the `compose.yml` file and inside this template. Maybe I am missing something here?🤔

cgalo5758 started working 2024-03-27 06:05:23 +00:00

cgalo5758 commented 2024-03-27 06:12:24 +00:00

Author

Copy Link

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file.

Maybe this is just something related to abra that I am not aware of?

Also... why is it passed as a template in the compose file? Nothing seems to need the templating in the file. Maybe this is just something related to `abra` that I am not aware of?

cgalo5758 commented 2024-06-21 21:02:57 +00:00

Author

Copy Link

Was also curious about this line:

exec ./sandbox/run.sh $@

What is run.sh? Does that directory even exist?

Was also curious about this line: ``` exec ./sandbox/run.sh $@ ``` What is run.sh? Does that directory even exist?

cgalo5758 canceled time tracking 2025-01-23 09:12:49 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

3.1.0+1.7.8

3.0.0+1.7.7

2.11.0+1.7.7

2.10.4+1.7.4

2.10.3+1.7.3

2.10.2+1.7.2

2.10.1+1.7.2

2.10.0+1.7.1

2.9.0+1.6.0

2.8.1+1.5.1

2.7.0+1.4.2

2.6.0+1.3.2

2.5.0+1.2.0

2.4.0+1.1.18

2.3.1+1.1.17

2.3.0+1.1.17

2.2.0+1.1.16

2.1.1+1.1.15

2.1.0+1.1.15

2.0.0+1.1.14

1.0.2+1.1.14

1.0.1+1.1.12

1.0.0+1.1.12

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/grist#2

No description provided.