coop-cloud/nextcloud
6
3
Fork 7
Code Issues 11 Pull Requests 1 Releases Wiki Activity

add postgres db #26

Merged
yksflip merged 4 commits from add-postgres-db into main 2022-05-18 08:36:27 +00:00
Conversation 1 Commits 4 Files Changed 5 +93 -28
yksflip commented 2022-05-12 10:22:39 +00:00
Owner
Copy Link

This PR moves the db service into two override files compose.mariadb.yml and compose.postgres.yml.

I tried to keep the mariadb as a default in compose.yml but found it a bit messy and was irritated with the docker-compose override logic. So I ended up using two seperate override files.

Existing installations need to add

COMPOSE_FILE="compose.yml"
COMPOSE_FILE="$COMPOSE_FILE:compose.mariadb.yml"

to their .env file to ensure mariadb is still used.

looking forward to your feedback ;)

Background

We were running Nextcloud on postgres before we moved to use coop-cloud and migrating from postgres -> mariadb seemed to be a too big pain.

This PR moves the db service into two override files `compose.mariadb.yml` and `compose.postgres.yml`. I tried to keep the mariadb as a default in `compose.yml` but found it a bit messy and was irritated with the docker-compose override logic. So I ended up using two seperate override files. Existing installations need to add ``` COMPOSE_FILE="compose.yml" COMPOSE_FILE="$COMPOSE_FILE:compose.mariadb.yml" ``` to their .env file to ensure mariadb is still used. looking forward to your feedback ;) **Background** We were running Nextcloud on postgres before we moved to use coop-cloud and migrating from postgres -> mariadb seemed to be a too big pain.
yksflip added 2 commits 2022-05-12 10:22:41 +00:00
split db definitions in override files 559ca6a95c
add backupbot for postgres
Some checks failed
continuous-integration/drone/pr Build is failing
Details
27e8e62675
yksflip added 1 commit 2022-05-12 10:23:17 +00:00
add release note
Some checks failed
continuous-integration/drone/pr Build is failing
Details
dba042ff46
decentral1se requested changes 2022-05-12 13:26:41 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM in the general approach!

LGTM in the general approach!
compose.mariadb.yml
@ -0,0 +17,4 @@
- MYSQL_ROOT_PASSWORD_FILE=/run/secrets/db_root_password
configs:
- source: my_tune
target: /etc/mysql/conf.d/my-tune.cnf
decentral1se commented 2022-05-12 13:25:37 +00:00
Owner
Copy Link

Forgot to migrate the config definition from the main compose.yml or?

Forgot to migrate the config definition from the main `compose.yml` or?
yksflip marked this conversation as resolved
compose.yml Outdated
@ -74,3 +70,3 @@
order: start-first
labels:
- "coop-cloud.${STACK_NAME}.version=1.0.0+23.0.1-fpm"
- "coop-cloud.${STACK_NAME}.version=1.0.0+23.0.3-fpm"
decentral1se commented 2022-05-12 13:23:45 +00:00
Owner
Copy Link

Should be 2.0.0+23.0.3-fpm or?

Should be `2.0.0+23.0.3-fpm` or?
yksflip marked this conversation as resolved
compose.yml
@ -95,3 +76,3 @@
cron:
image: nextcloud:23.0.1-fpm
image: nextcloud:23.0.3-fpm
decentral1se commented 2022-05-12 13:22:04 +00:00
Owner
Copy Link

I would also mention this patch upgrade in the realease notes.

I would also mention this patch upgrade in the realease notes.
yksflip marked this conversation as resolved
yksflip added 1 commit 2022-05-18 08:33:14 +00:00
fixup stuff
Some checks failed
continuous-integration/drone/pr Build is failing
Details
ea48f6837c
yksflip merged commit 12eea19cab into main 2022-05-18 08:36:27 +00:00
yksflip referenced this issue from a commit 2022-05-18 08:36:27 +00:00
add postgres db (#26)
yksflip deleted branch add-postgres-db 2022-05-18 08:36:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
decentral1se
Labels
Clear labels
bug
Something is not working
documentation
For issues that are calling out documentation gap
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
3wordchant aadil abra-bot ammaratef45 Apfelwurm appletalk arjan basebuilder Brooke carla cas codegod100 coopcloud cyrnel decentral1se fauno flancian Frando iexos jade javielico jmakdah2 joe-irving kawaiipunk knoflook kolaente lambdabundesverband linnealovespie marlon mayel mirsal moritz nicksellen notplants p4u1 pau pharaohgraphy renovate-bot ripclap rix rscmbbng sef simon sixsmith stevensting tobias trav val virtualboys wolcen wykwit xynosis yksflip
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#26
No description provided.
Delete Branch "add-postgres-db"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?