coop-cloud/nextcloud
coop-cloud
/
nextcloud
5
1
Fork 3
Code Issues 6 Pull Requests Releases Wiki Activity

add postgres db #26

Merged
yksflip merged 4 commits from add-postgres-db into main 2022-05-18 08:36:27 +00:00
Conversation 0 Commits 4 Files Changed 5 +93 -28
yksflip commented 2022-05-12 10:22:39 +00:00
Owner
Copy Link

This PR moves the db service into two override files compose.mariadb.yml and compose.postgres.yml.

I tried to keep the mariadb as a default in compose.yml but found it a bit messy and was irritated with the docker-compose override logic. So I ended up using two seperate override files.

Existing installations need to add

COMPOSE_FILE="compose.yml"
COMPOSE_FILE="$COMPOSE_FILE:compose.mariadb.yml"

to their .env file to ensure mariadb is still used.

looking forward to your feedback ;)

Background

We were running Nextcloud on postgres before we moved to use coop-cloud and migrating from postgres -> mariadb seemed to be a too big pain.

This PR moves the db service into two override files `compose.mariadb.yml` and `compose.postgres.yml`. I tried to keep the mariadb as a default in `compose.yml` but found it a bit messy and was irritated with the docker-compose override logic. So I ended up using two seperate override files. Existing installations need to add ``` COMPOSE_FILE="compose.yml" COMPOSE_FILE="$COMPOSE_FILE:compose.mariadb.yml" ``` to their .env file to ensure mariadb is still used. looking forward to your feedback ;) **Background** We were running Nextcloud on postgres before we moved to use coop-cloud and migrating from postgres -> mariadb seemed to be a too big pain.
yksflip added 2 commits 2022-05-12 10:22:41 +00:00
continuous-integration/drone/pr Build is failing Details
27e8e62675 add backupbot for postgres
yksflip added 1 commit 2022-05-12 10:23:17 +00:00
continuous-integration/drone/pr Build is failing Details
dba042ff46 add release note
decentral1se requested changes 2022-05-12 13:26:41 +00:00
decentral1se left a comment
Owner
Copy Link

LGTM in the general approach!

LGTM in the general approach!
compose.mariadb.yml
@ -0,0 +17,4 @@
- MYSQL_ROOT_PASSWORD_FILE=/run/secrets/db_root_password
configs:
- source: my_tune
target: /etc/mysql/conf.d/my-tune.cnf
decentral1se commented 2022-05-12 13:25:37 +00:00
Owner
Copy Link

Forgot to migrate the config definition from the main compose.yml or?

Forgot to migrate the config definition from the main `compose.yml` or?
yksflip marked this conversation as resolved
compose.yml Outdated
@ -74,3 +70,3 @@
order: start-first
labels:
- "coop-cloud.${STACK_NAME}.version=1.0.0+23.0.1-fpm"
- "coop-cloud.${STACK_NAME}.version=1.0.0+23.0.3-fpm"
decentral1se commented 2022-05-12 13:23:45 +00:00
Owner
Copy Link

Should be 2.0.0+23.0.3-fpm or?

Should be `2.0.0+23.0.3-fpm` or?
yksflip marked this conversation as resolved
compose.yml
@ -95,3 +76,3 @@
cron:
image: nextcloud:23.0.1-fpm
image: nextcloud:23.0.3-fpm
decentral1se commented 2022-05-12 13:22:04 +00:00
Owner
Copy Link

I would also mention this patch upgrade in the realease notes.

I would also mention this patch upgrade in the realease notes.
yksflip marked this conversation as resolved
yksflip added 1 commit 2022-05-18 08:33:14 +00:00
continuous-integration/drone/pr Build is failing Details
ea48f6837c fixup stuff
yksflip merged commit 12eea19cab into main 2022-05-18 08:36:27 +00:00
yksflip referenced this issue from a commit 2022-05-18 08:36:27 +00:00
add postgres db (#26)
yksflip deleted branch add-postgres-db 2022-05-18 08:36:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
decentral1se
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/nextcloud#26
No description provided.
Delete Branch "add-postgres-db"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?